Created attachment 152890 [details] svn diff that reflects the changes I use pgworksheet, and noticed the WWW link was no longer any good. As it appears that it's no longer maintained upstream. I thought I'd like to keep it current with the ports it works with - esp; the up coming python3. So this is a request for MAINTAINER. Files Affected: Makefile adds MAINTAINED LICENSE pkg-descr - changes WWW That's pretty much it, for now. Next version will add the support of lang/python3. Please find the svn diff, and a session log against these changes, attached. Thanks!
Created attachment 152891 [details] session LOG reflecting the changes
Thanks for your submission Christer, Unless you're part of the upstream project for pgworksheet, I'm not sure the change added to pkg-descr is warranted. MAINTAINER=<email> already speaks to who the current maintainer is. If you are indeed working with upstream, then it may be worth clarifying in pkg-descr that you are the 'port' maintainer, unless you intended something different. Please update the patch accordingly, and if applicable. Also, if a port is unmaintained, you can use the term "Take MAINTAINERship" rather than "Request" maintainership. The latter implies an existing maintainer, and requires approval. The person committing the change should check for approval in any case.
Created attachment 153062 [details] modifications to original submission, as recommended by Kubilay Kocak
(In reply to Kubilay Kocak from comment #2) > Thanks for your submission Christer, > > Unless you're part of the upstream project for pgworksheet, I'm not sure the > change added to pkg-descr is warranted. MAINTAINER=<email> already speaks to > who the current maintainer is. > > If you are indeed working with upstream, then it may be worth clarifying in > pkg-descr that you are the 'port' maintainer, unless you intended something > different. Good advise. Thank you. I have indicated my intention(s) upstream. Also; as the previous WWW provides no support/indication for pgworksheet. pgworksheet seemed better served having a page that reflects it's usage, intentions, and support. So the change in the WWW seemed warranted. > > Please update the patch accordingly, and if applicable. Done, in new svn diff attached. > > Also, if a port is unmaintained, you can use the term "Take MAINTAINERship" > rather than "Request" maintainership. The latter implies an existing > maintainer, and requires approval. The person committing the change should > check for approval in any case. Thank you, Kubilay Kocak. I appreciate the clarity you provided on that, and will do so, going forward. Thank you very much for all your help! --Chris
A commit references this bug: Author: robak Date: Thu Feb 26 15:10:18 UTC 2015 New revision: 380014 URL: https://svnweb.freebsd.org/changeset/ports/380014 Log: databases/pgworksheet: set MAINTAINER and fixes - Set MAINTAINER to portmaster@BSDforge.com - Adjust pkg-descr text - Fix WWW url PR: 197557 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Changes: head/databases/pgworksheet/Makefile head/databases/pgworksheet/pkg-descr
Committed, thanks for stepping up and taking care of that port!
(In reply to Bartek Rutkowski from comment #6) > Committed, thanks for stepping up and taking care of that port! Thank you, for taking the time to work on this with me, Bartek Rutkowski! --Chris