Created attachment 153144 [details] pspp.diff - Bump PORTREVISION. - Strip shared objects. - Add DOCS as configure option. - Fix pkg-plist. - Take maintainership. I use this port, so I want to maintain it. Q/A tests will be provided soon as attachment. % portlint -ac WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 1 warning found.
Are you still interested in maintaining the port? This bugs lacks any non-obsoleted patches.
Created attachment 153492 [details] pspp.diff Good patch attached.
(In reply to Jan Beich from comment #1) Yes! I'm still interested to maintain this port :)
Build log on 11-CURRENT/i386 https://fbsd.es/~cpm/freebsd/logs/pspp-0.8.4_1.log
Created attachment 153632 [details] alternative version Maybe also install Emacs mode for syntax highlightling and facilitating indentation/commenting in .sps files. >+OPTIONS_DEFAULT= DOCS NLS Already there, see Mk/bsd.options.mk. >+post-install: >+.for f in libpspp libpspp-core >+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}/${f}-${PORTVERSION}.so >+.endfor >+ >+.if ${PORT_OPTIONS:MGUI} >+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/glade3/modules/libglade-psppire.so.0.0.0 Why? install-strip is enough or you can simplify the following GUI_INSTALL_TARGET= install-strip ... GUI_INSTALL_TARGET_OFF= install-strip into INSTALL_TARGET= install-strip GUI_INSTALL_TARGET= ... > +DOCS= ABOUT-NLS AUTHORS COPYING ChangeLog INSTALL NEWS ONEWS \ > + README THANKS TODO > + [...] > + ${MKDIR} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC} && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} [...] > +%%PORTDOCS%%%%DOCSDIR%%/ABOUT-NLS > +%%PORTDOCS%%%%DOCSDIR%%/AUTHORS > +%%PORTDOCS%%%%DOCSDIR%%/COPYING > +%%PORTDOCS%%%%DOCSDIR%%/ChangeLog > +%%PORTDOCS%%%%DOCSDIR%%/INSTALL > +%%PORTDOCS%%%%DOCSDIR%%/NEWS > +%%PORTDOCS%%%%DOCSDIR%%/ONEWS > +%%PORTDOCS%%%%DOCSDIR%%/README > +%%PORTDOCS%%%%DOCSDIR%%/THANKS > +%%PORTDOCS%%%%DOCSDIR%%/TODO Unless you want to keep everything in one place at the expense of listing installed files several times the above can be simplified to: PORTDOCS= AUTHORS ChangeLog NEWS ONEWS README THANKS TODO (cd ${WRKSRC} && ${COPYTREE_SHARE} \ "${PORTDOCS}" ${STAGEDIR}${DOCSDIR}) ABOUT-NLS is generic help-file from gettext. COPYING is redundant because LICENSE=GPLv3 already installs /usr/ports/Templates/Licenses/GPLv3. INSTALL is pointless for people using the FreeBSD port/package and not trying to figure out how to compile pspp themselves.
A commit references this bug: Author: jbeich Date: Sun Mar 1 16:41:26 UTC 2015 New revision: 380210 URL: https://svnweb.freebsd.org/changeset/ports/380210 Log: - Install more DOCS [1] - Install Emacs mode [2] - Simplify INSTALL_TARGET [2] - Unbreak build when NLS=off [2] - Pass maintainership [1] PR: 197786 Submitted by: Carlos Jacobo Puga Medina <cpm@fbsd.es> [1] Approved by: Carlos Jacobo Puga Medina <cpm@fbsd.es> [2] Changes: head/math/pspp/Makefile head/math/pspp/pkg-plist
Thanks. Committed.
Comment on attachment 153632 [details] alternative version Cancelling maintainer-approval over maintainer-feedback+. Bug 197656 should have fixed maintainer-approval for non-committers, so the next time try using it instead.