Bug 197807 - print/foxitreader: Broken if DOCS option is unchecked
Summary: print/foxitreader: Broken if DOCS option is unchecked
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 197808 197809 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-18 20:44 UTC by Johannes Jost Meixner
Modified: 2015-02-22 23:41 UTC (History)
1 user (show)

See Also:

Attachments
Add conditional deploying of the PDF Manual. (484 bytes, patch)
2015-02-18 20:44 UTC, Johannes Jost Meixner 		xmj: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2015-02-18 20:44:15 UTC 
Created attachment 153161 [details]
Add conditional deploying of the PDF Manual.

The foxitreader port uses a port option for DOCS to determine wether a PDF should be downloaded, but then unconditionally tries to install said PDF into DOCSDIR.

This fails, lacking the file in DISTDIR.

Patch attached fixes this.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-02-18 20:57:00 UTC 
*** Bug 197808 has been marked as a duplicate of this bug. ***
Comment 2 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:05:11 UTC 
Hi, thanks for reporting that. I just updated the port to 5.1.8, and it no longer installs that file. May I close this PR?
Comment 3 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:14:09 UTC 
Ops, I don't know how, but I have read spideroak instead of foxitreader. So I approve that patch. :-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-18 21:19:07 UTC 
A commit references this bug:

Author: nivit
Date: Wed Feb 18 21:18:42 UTC 2015
New revision: 379314
URL: https://svnweb.freebsd.org/changeset/ports/379314

Log:
  - Fix installation when DOCS option is off

  PR:	197807
  Submitted by:	xmj

Changes:
  head/print/foxitreader/Makefile
Comment 5 Nicola Vitale freebsd_committer freebsd_triage 2015-02-18 21:22:26 UTC 
Committed, thanks for the PR.
Comment 6 Nicola Vitale freebsd_committer freebsd_triage 2015-02-22 23:41:52 UTC 
*** Bug 197809 has been marked as a duplicate of this bug. ***