Bug 197948 - devel/libosmo*: simplify and misc fixes
Summary: devel/libosmo*: simplify and misc fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 11:18 UTC by Jan Beich
Modified: 2015-02-24 08:13 UTC (History)
1 user (show)

See Also:

Attachments
v1 (8.96 KB, patch)
2015-02-23 11:18 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-02-23 11:18:16 UTC 
Created attachment 153371 [details]
v1

- Unbreak on DragonFly
- Unbreak on big-endian archs [1]
- Unbreak and rename DOCS option [2]
- CONFLICTS with multimedia/libmtp [3]
- Convert to USES=autoreconf
- Convert to USES=pathfix
- Convert to INSTALL_TARGET=install-strip
- Convert to PORTDOCS
- Fix whitespace
- Bump PORTREVISION for [1], [2], [3]

poudriere bulk -t 10.1R i386 logs:
http://slexy.org/view/s21CtTPpbr libosmocore-0.8.0 DOXYGEN=on
http://slexy.org/view/s2nHU1fuN9 libosmo-abis-0.3.1
http://slexy.org/view/s2Hnfm2m5w libosmo-netif-0.0.4
http://slexy.org/view/s2bQQhqp8Z libosmo-sccp-0.0.6.3_1
http://slexy.org/view/s2CVGh9r0P libosmocore-0.8.0

Also green on 8.4R amd64, 9.3R i386, 10.0R amd64.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2015-02-23 12:51:38 UTC 
Endian stuff is tricky. A portable code would have to account for all the places endian.h can be found and all the underscores/prefixes various implementations have. It's way easier to just include endian.h in the few places that have

  #if __BYTE_ORDER == __LITTLE_ENDIAN

and sed(1) everything into shape that builds on BSDs.

Ironically, the above conditional would compile without warnings even when the macros are undefined. They're implicitly converted to 0 and thus the comparison is always true.
Comment 2 Nikola Kolev 2015-02-23 16:19:50 UTC 
I'm agree with ports changes.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-24 08:01:10 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Feb 24 08:00:59 UTC 2015
New revision: 379763
URL: https://svnweb.freebsd.org/changeset/ports/379763

Log:
  - Unbreak on DragonFly
  - Unbreak on big-endian archs [1]
  - Unbreak and rename DOCS option [2]
  - Convert to USES=autoreconf
  - Convert to USES=pathfix
  - Convert to INSTALL_TARGET=install-strip
  - Convert to PORTDOCS
  - Fix whitespace
  - Bump PORTREVISION for [1], [2]

  Differential Revision:	https://reviews.freebsd.org/D1947
  PR:		197948
  Reviewed by:	marino, pi
  Approved by:	Nikola Kolev <koue@chaosophia.net> (maintainer)

Changes:
  head/devel/libosmo-abis/Makefile
  head/devel/libosmo-sccp/Makefile
  head/devel/libosmo-sccp/files/
  head/devel/libosmocore/Makefile
  head/devel/libosmocore/files/patch-Makefile.am
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-24 08:03:11 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Feb 24 08:03:08 UTC 2015
New revision: 379764
URL: https://svnweb.freebsd.org/changeset/ports/379764

Log:
  Register CONFLICTS between libmtp and libosmo-sccp

  Differential Revision:	https://reviews.freebsd.org/D1947
  PR:		197948
  Reviewed by:	marino, pi
  Approved by:	Nikola Kolev <koue@chaosophia.net> (maintainer)

Changes:
  head/devel/libosmo-sccp/Makefile
  head/multimedia/libmtp/Makefile