Bug 198113 - Fix security/pam_ocra build with clang 3.6.0
Summary: Fix security/pam_ocra build with clang 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks: 197395
  Show dependency tree / graph
 
Reported: 2015-03-01 00:05 UTC by Dimitry Andric
Modified: 2015-03-05 12:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sg2342)

Attachments
Constify two local variables to avoid -Wcast-qual warnings (1.20 KB, patch)
2015-03-01 00:05 UTC, Dimitry Andric 		no flags Details | Diff
update security/pam_ocra to 1.2 (950 bytes, patch)
2015-03-04 04:12 UTC, Stefan Grundmann 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-03-01 00:05:58 UTC 
Created attachment 153633 [details]
Constify two local variables to avoid -Wcast-qual warnings

During the exp-run in bug 197395, it was found that security/pam_ocra gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/pam_ocra-1.1.log

These errors are -Werror warnings about dropping const qualifiers.  This is easy to fix, as in the attached patch, which adds two const qualifiers to local variables.  No functional change.
Comment 1 Stefan Grundmann 2015-03-04 04:12:21 UTC 
Created attachment 153759 [details]
update security/pam_ocra to 1.2

I have included the proposed fix in the upstream git repo.
attached patch updates the port to 1.2
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-05 12:44:20 UTC 
A commit references this bug:

Author: robak
Date: Thu Mar  5 12:43:56 UTC 2015
New revision: 380487
URL: https://svnweb.freebsd.org/changeset/ports/380487

Log:
  security/pam_ocra: update 1.1 -> 1.2

  - Include upstream accepted Clang 3.6.0 fixes by Dimitry Andric <dim@FreeBSD.org>

  PR:		198113
  Submitted by:	Stefan Grundmann <sg2342@googlemail.com>

Changes:
  head/security/pam_ocra/Makefile
  head/security/pam_ocra/distinfo
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-05 12:44:50 UTC 
Committed, thanks for your work guys!