Bug 198209 - Fix games/cataclysm-dda build with clang 3.6.0
Summary: Fix games/cataclysm-dda build with clang 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks: 197395
  Show dependency tree / graph
 
Reported: 2015-03-02 21:29 UTC by Dimitry Andric
Modified: 2015-03-19 20:59 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wulf)

Attachments
Disable -Winconsistent-missing-override for clang 3.6.0 and higher (446 bytes, patch)
2015-03-02 21:29 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-03-02 21:29:04 UTC 
Created attachment 153697 [details]
Disable -Winconsistent-missing-override for clang 3.6.0 and higher

During the exp-run in bug 197395, it was found that games/cataclysm-dda gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/cataclysm-dda-0.B,1.log

These are all -Werror warnings about missing "override" identifiers on member functions.  They are rather benign, and fixing them all is not very hard, but it causes a lot of churn.  It is probably less intrusive to turn off the warning for clang 3.6.0 and higher.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-03-19 20:57:26 UTC 
A commit references this bug:

Author: robak
Date: Thu Mar 19 20:57:13 UTC 2015
New revision: 381692
URL: https://svnweb.freebsd.org/changeset/ports/381692

Log:
  games/cataclysm-dda: fix clang 3.6 build

  - Maintainer's timeout (wulf@cicgroup.ru)

  PR:		198209
  Submitted by:	Dimitry Andric <dim@FreeBSD.org>

Changes:
  head/games/cataclysm-dda/Makefile
Comment 2 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-19 20:59:18 UTC 
Committed, thanks for your work!