Bug 198225 - devel/godot: don't require openssl from ports, fix build with ccache
Summary: devel/godot: don't require openssl from ports, fix build with ccache
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 13:38 UTC by Dmitry Marakasov
Modified: 2015-03-05 15:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (FreeBSD)

Attachments
Patch (2.85 KB, patch)
2015-03-03 13:38 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-03-03 13:38:24 UTC 
Created attachment 153711 [details]
Patch

- Software using pkg-config for openssl detection is not a reason to require openssl from ports; fix detection and drop the dependency
- Fix scons to pass full environment to child processes; among other things, this fixes build with ccache which needs its environment variables to be respected
Comment 1 Shane 2015-03-05 03:38:06 UTC 
This patch look good to me, can someone commit.

Thanks
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-05 15:44:47 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Mar  5 15:44:39 UTC 2015
New revision: 380508
URL: https://svnweb.freebsd.org/changeset/ports/380508

Log:
  - Don't require openssl from ports
  - Make SCons preserve environment for e.g. ccache to work properly

  PR:		198225
  Submitted by:	amdmi3
  Approved by:	FreeBSD@ShaneWare.Biz (maintainer)

Changes:
  head/devel/godot/Makefile
  head/devel/godot/files/patch-SConstruct
  head/devel/godot/files/patch-platform_x11_detect.py