Bug 198322 - [patch] shells/fish: include builtin manpages
Summary: [patch] shells/fish: include builtin manpages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lars Engels
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-03-05 19:15 UTC by martin
Modified: 2015-07-26 09:13 UTC (History)
3 users (show)

See Also:

Attachments
Patch to include builtin manpages that are missing (3.38 KB, patch)
2015-03-05 19:15 UTC, martin 		no flags Details | Diff
Fix patch for current port version (3.60 KB, patch)
2015-05-17 06:05 UTC, martin 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description martin 2015-03-05 19:15:38 UTC 
Created attachment 153851 [details]
Patch to include builtin manpages that are missing

This patch fixes shells/fish to include its man pages that are otherwise missing when using the man function within fish.

It also fixes the pending bug #196661 as approved by upstream (fix duplicated here, so you don't need to care further about bug #196661, just close it when you commit this patch).
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-03-05 21:59:51 UTC 
Fix Summary and notify maintainer.
Comment 2 John Marino freebsd_committer freebsd_triage 2015-05-03 13:49:16 UTC 
This timed out weeks ago  I'll move it to patch-ready (no approval needed)
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2015-05-11 09:20:44 UTC 
Removing patch-ready. This patch requires some rework.

@Martin: could you resubmit the patch that
- applies cleanly to an up-to-date ports tree
- is accepted by portlint -ca
If you have a poudriere log that demonstrates your patch keeps the port in good shape, please attach this as well. Thanks!
Comment 4 martin 2015-05-17 06:05:06 UTC 
Created attachment 156847 [details]
Fix patch for current port version

I don't use fish anymore, but I feel responsible to fix the patch. So, here is my next try.


Following changes to the patch have been done:

1) Removed patch suggested by upstream from Makefile, because the other variant has been selected.
2) Added man/man1 contents to package list with DATADIR prefix (once again, in case new files have been added).
3) Added suffix .gz for the manpages and added the directory to MANPAGES in Makefile.
4) Checked, if installs (OK).
5) Checked, if man pages are usable (OK).
6) portlint -ca successful.

Final remark:

There is a deprecation warning about USE_AUTOTOOLS that I don't fix in this patch, because it is not the subject of this change (and it seems to work without it).
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-07-26 08:35:29 UTC 
A commit references this bug:

Author: lme
Date: Sun Jul 26 08:35:19 UTC 2015
New revision: 392912
URL: https://svnweb.freebsd.org/changeset/ports/392912

Log:
  - Removed patch suggested by upstream from Makefile, because the other variant has been selected.
  - Add additional manpages
  - While here, switch to USES= autoreconf and GNU_CONFIGURE
  - Bump PORTREVISION

  PR:		198322
  Submitted by:	Martin Sugioarto <martin@sugioarto.com>
  Approved by:	maintainer (timeout after almost 5 months)
  Committed from:	Essen FreeBSD Hackathon

Changes:
  head/shells/fish/Makefile
  head/shells/fish/pkg-plist
Comment 6 Lars Engels freebsd_committer freebsd_triage 2015-07-26 09:13:57 UTC 
Committed, with minor changes, thanks!