Bug 198485 - net/quagga: 0.99.24 changes break bgp-announce logic
Summary: net/quagga: 0.99.24 changes break bgp-announce logic
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 09:44 UTC by lerik
Modified: 2015-03-10 11:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lerik 2015-03-10 09:44:30 UTC 
In rev 380374 by mat@, along with update to version 0.99.24, the makefile for Quagga was changed. The following change is the problem:

Line 75 was changed as follows:

-NO_BGP_ANNOUNCE_CONFIGURE_ARGS+=--disable-bgp-announce
+NO_BGP_ANNOUNCE_CONFIGURE_ENABLE=       bgp-announce

This inverts the logic - with "NO_BGP_ANNOUNCE" set in options, the configure option "--enable-bgp-announce" is set. Vice versa, without it, "--disable-bgp-announce" is set in configure, and bgpd does not announce any routes (this then becomes normal behaviour with default options)

This breaks default behaviour, and the binary package build of Quagga now does NOT announce BGP routes at all!
Comment 1 Daniel Austin 2015-03-10 10:13:29 UTC 
I can confirm I have seen this behaviour too (but hadn't had chance to debug it)
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-10 11:31:12 UTC 
A commit references this bug:

Author: mat
Date: Tue Mar 10 11:30:45 UTC 2015
New revision: 380906
URL: https://svnweb.freebsd.org/changeset/ports/380906

Log:
  Make quagga announce BGP routes by default.

  PR:		198485
  Submitted by:	lerik nolink net
  Pointy hat to:	mat
  Sponsored by:	Absolight

Changes:
  head/net/quagga/Makefile
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2015-03-10 11:32:50 UTC 
Damn I'm stupid, thanks for noticing this, I was wondering this morning why one of my quagga was not announcing anything via BGP...