Created attachment 154289 [details] h2o 1.1.1 Update h2o to latest version.
Lgtm in general. I'm on vacation til mid April so can't respond further. Not clear why the additional changes other than bumping commit/tags are required but please go ahead in my absence.
(In reply to Dave Cottlehuber from comment #1) H2O builds fine with multiple jobs so MAKE_JOBS_UNSAFE can be removed. Changing do-install to post-install automatically installs files into STAGEDIR for us. H2O reads config and SSL certificates before setuid() so we don't need to change the user/group of /usr/local/etc/h2o to H2O_USER.
Created attachment 155619 [details] h2o 1.2.0 Update h2o to 1.2.0. https://github.com/h2o/h2o/releases/tag/v1.2.0 Remove dependency on libyaml. (bundled in h2o) Add option to use bundled libressl.
Thanks Colin for the explanation. LGTM on 10.1 amd64, I will read up on how to get this committed ASAP now that I'm back from holidays. BTW feel free to co-maintain this port if you wish to!
Have discussed some improvements to be made with the maintainer (Dave). Pending an updated patch + QA results
current port status incl update from IRC discussion w koobs@. 1. GH_* changes - deprecated GH_COMMIT - GH_ACCOUNT can default to name - fix distfile as a result of this 2. lint & build status - add portlint / poudriere status as part of submission 3. SSL - should use PORTS SSL, not BASE. My bad! 4. SSL - BUNDLED_LIBRESSL is not ideal, it should instead link to security/libressl or security/openssl (which is at 1.0.2a already so should be compatible) - use OPTIONS to switch between SSL alternatives 5. libYAML - should we use textproc/libyaml instead of bundled version? AFAICT there are no custom libyaml patches dch@ - I'll handle 1,2,3, and submit a new patch with just those changes. colin@ are you able to take care of 4? wrt 5, feedback requested on what makes sense.
Created attachment 156335 [details] updated patch from dch@ lacking SSL OPTION
Comment on attachment 156335 [details] updated patch from dch@ lacking SSL OPTION # portlint WARN: Makefile: possible use of absolute pathname "/var/log/${PORTNAME}...". WARN: Makefile: possible use of absolute pathname "/var/run/${PORTNAME}...". 0 fatal errors and 2 warnings found. # poudriere http://pkg.skunkwerks.at/poudriere/data/10_1_amd64-default/2015-05-04_12h40m11s/logs/h2o-1.2.0.log
(In reply to Dave Cottlehuber from comment #8) LGTM on 9.3 also, http://pkg.skunkwerks.at/poudriere/data/9_3_amd64-default/2015-05-04_13h13m27s/logs/h2o-1.2.0.log
wrt #5 let's stick with ports libyaml as upstream confirms there are no specific patches on top of the imported bundle. ports is currently at 0.1.6 and bundled is 0.1.5.
status: waiting til 2015/05/18 for respoonse from "Colin" wrt SSL patch, or go ahead without that specific change.
(In reply to Dave Cottlehuber from comment #11) If anyone wants to use the libressl from ports, they can just add: WITH_OPENSSL_PORT=yes OPENSSL_PORT=security/libressl to their make.conf.
A commit references this bug: Author: wen Date: Tue May 19 06:10:30 UTC 2015 New revision: 386743 URL: https://svnweb.freebsd.org/changeset/ports/386743 Log: - Update to 1.2.0 PR: 198573 Submitted by: anonymous.bug.report@gmail.com Approved by: dch@skunkwerks.at(maintainer) Changes: head/www/h2o/Makefile head/www/h2o/distinfo head/www/h2o/pkg-plist