Bug 198692 - p4 ports uselessly use @exec in Makefile
Summary: p4 ports uselessly use @exec in Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Gordon Tetlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-18 22:21 UTC by Baptiste Daroussin
Modified: 2015-07-19 04:34 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Daroussin freebsd_committer freebsd_triage 2015-03-18 22:21:36 UTC 
All most @exec from the p4 makefile can be expressed properly in plist avoiding the package system to have to execute a command
Comment 1 Gordon Tetlow freebsd_committer freebsd_triage 2015-04-18 15:47:32 UTC 
Will look into fixing this during the next round of updated.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-18 23:46:10 UTC 
A commit references this bug:

Author: gordon
Date: Sat Jul 18 23:46:02 UTC 2015
New revision: 392477
URL: https://svnweb.freebsd.org/changeset/ports/392477

Log:
  Update devel/p4d to 2015.1/1045032 to fix broken fetch.
  Remove unneeded exec statements by moving them into
  the port stage or init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3087
  Approved by:	mat (mentor)
  MFH:		2015Q3

Changes:
  head/devel/p4d/Makefile
  head/devel/p4d/distinfo.freebsd100x86
  head/devel/p4d/distinfo.freebsd100x86_64
  head/devel/p4d/distinfo.freebsd70x86
  head/devel/p4d/distinfo.freebsd70x86_64
  head/devel/p4d/files/p4d.in
  head/devel/p4d/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-07-18 23:53:15 UTC 
A commit references this bug:

Author: gordon
Date: Sat Jul 18 23:52:31 UTC 2015
New revision: 392479
URL: https://svnweb.freebsd.org/changeset/ports/392479

Log:
  Update devel/p4ftpd to 2015..1/1024208 fixing broken distfile.
  Move unneeded execs from the plist into the init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3089
  Approved by:	mat (mentor)
  MFH:		2015Q3

Changes:
  head/devel/p4ftpd/Makefile
  head/devel/p4ftpd/distinfo.freebsd100x86
  head/devel/p4ftpd/distinfo.freebsd100x86_64
  head/devel/p4ftpd/distinfo.freebsd70x86
  head/devel/p4ftpd/distinfo.freebsd70x86_64
  head/devel/p4ftpd/files/p4ftpd.in
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-07-18 23:55:17 UTC 
A commit references this bug:

Author: gordon
Date: Sat Jul 18 23:54:18 UTC 2015
New revision: 392480
URL: https://svnweb.freebsd.org/changeset/ports/392480

Log:
  Update devel/p4p to 2015.1/1126382 to fix the broken distfile.
  Move plist execs to the stage and init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3092
  Approved by:	mat (mentor)
  MFH:		2015Q3

Changes:
  head/devel/p4p/Makefile
  head/devel/p4p/distinfo.freebsd100x86
  head/devel/p4p/distinfo.freebsd100x86_64
  head/devel/p4p/distinfo.freebsd70x86
  head/devel/p4p/distinfo.freebsd70x86_64
  head/devel/p4p/files/p4p.in
  head/devel/p4p/pkg-plist
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-07-19 04:32:56 UTC 
A commit references this bug:

Author: gordon
Date: Sun Jul 19 04:32:22 UTC 2015
New revision: 392484
URL: https://svnweb.freebsd.org/changeset/ports/392484

Log:
  MFH: r392477

  Update devel/p4d to 2015.1/1045032 to fix broken fetch.
  Remove unneeded exec statements by moving them into
  the port stage or init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3087
  Approved by:	mat (mentor)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/devel/p4d/Makefile
  branches/2015Q3/devel/p4d/distinfo.freebsd100x86
  branches/2015Q3/devel/p4d/distinfo.freebsd100x86_64
  branches/2015Q3/devel/p4d/distinfo.freebsd70x86
  branches/2015Q3/devel/p4d/distinfo.freebsd70x86_64
  branches/2015Q3/devel/p4d/files/p4d.in
  branches/2015Q3/devel/p4d/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-07-19 04:33:57 UTC 
A commit references this bug:

Author: gordon
Date: Sun Jul 19 04:33:28 UTC 2015
New revision: 392485
URL: https://svnweb.freebsd.org/changeset/ports/392485

Log:
  MFH: r392479

  Update devel/p4ftpd to 2015..1/1024208 fixing broken distfile.
  Move unneeded execs from the plist into the init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3089
  Approved by:	mat (mentor)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/devel/p4ftpd/Makefile
  branches/2015Q3/devel/p4ftpd/distinfo.freebsd100x86
  branches/2015Q3/devel/p4ftpd/distinfo.freebsd100x86_64
  branches/2015Q3/devel/p4ftpd/distinfo.freebsd70x86
  branches/2015Q3/devel/p4ftpd/distinfo.freebsd70x86_64
  branches/2015Q3/devel/p4ftpd/files/p4ftpd.in
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-07-19 04:34:59 UTC 
A commit references this bug:

Author: gordon
Date: Sun Jul 19 04:34:36 UTC 2015
New revision: 392486
URL: https://svnweb.freebsd.org/changeset/ports/392486

Log:
  MFH: r392480

  Update devel/p4p to 2015.1/1126382 to fix the broken distfile.
  Move plist execs to the stage and init script.

  PR:		198692
  Differential Revision:	https://reviews.freebsd.org/D3092
  Approved by:	mat (mentor)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/devel/p4p/Makefile
  branches/2015Q3/devel/p4p/distinfo.freebsd100x86
  branches/2015Q3/devel/p4p/distinfo.freebsd100x86_64
  branches/2015Q3/devel/p4p/distinfo.freebsd70x86
  branches/2015Q3/devel/p4p/distinfo.freebsd70x86_64
  branches/2015Q3/devel/p4p/files/p4p.in
  branches/2015Q3/devel/p4p/pkg-plist