Bug 198745 - [patch] [exp-run] devel/sdl12 import upstream fix to sdl-config script behavior
Summary: [patch] [exp-run] devel/sdl12 import upstream fix to sdl-config script behavior
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL: https://reviews.freebsd.org/D2066
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-03-20 18:00 UTC by Guido Falsi
Modified: 2015-03-21 18:18 UTC (History)
3 users (show)

See Also:
mva: maintainer-feedback+
madpilot: exp-run?

Attachments
proposed patch (1012 bytes, patch)
2015-03-20 18:00 UTC, Guido Falsi 		mva: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2015-03-20 18:00:37 UTC 
Created attachment 154585 [details]
proposed patch

I have made a patch against the sdl12 port which is equivalent to this upstream change:

http://hg.libsdl.org/SDL/rev/7b87c1773b3e

I simply applied it to configure directly, since I was unable to make it work as a patch to configure.ac due to errors from the autotools.

This is needed to make the update of games/0ad (which I maintain) to version 0.0.18.

I'd like to have an exp-run to make sure this change does not brake any other port depending on sdl 1.2.

The attached patch is also up for review on phabric:

https://reviews.freebsd.org/D2066

Please feel free to comment on the review if needed.

Thanks.
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2015-03-20 21:53:57 UTC 
Looks good to me, thanks. I did not yet comment on review D2066, but will do so tomorrow. portmgr can pick it up for an exp-run.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2015-03-20 21:58:55 UTC 
Take for exp-run
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2015-03-21 17:18:39 UTC 
Exp-run results on 10.1 amd64:

http://package22.nyi.freebsd.org/build.html?mastername=101amd64-default&build=2015-03-20_22h04m42s

No new failures related to sdl12.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2015-03-21 18:18:23 UTC 
Committed, thanks to all for support!
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-03-21 18:18:41 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Mar 21 18:17:45 UTC 2015
New revision: 381811
URL: https://svnweb.freebsd.org/changeset/ports/381811

Log:
  Import upstream fix to stop sdl-config from unconditionally defining
  _GNU_SOURCE.

  PR:		198745
  Submitted by:	me
  Differential Revision:	https://reviews.freebsd.org/D2066
  Approved by:	mva@ (maintainer)
  Reported by:	Georg Kilzer (leper)
  Obtained from:	http://hg.libsdl.org/SDL/rev/7b87c1773b3e

Changes:
  head/devel/sdl12/Makefile
  head/devel/sdl12/files/patch-configure