Bug 198820 - Sustaining patches for devel/svk - as used on the freebsd cluster
Summary: Sustaining patches for devel/svk - as used on the freebsd cluster
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Peter Wemm
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-03-23 05:45 UTC by Peter Wemm
Modified: 2015-03-23 17:54 UTC (History)
1 user (show)

See Also:

Attachments
Patch for syntax error that traps on perl 5.18 (575 bytes, patch)
2015-03-23 05:46 UTC, Peter Wemm 		no flags Details | Diff
Patch to work around perl 5.16+ (429 bytes, patch)
2015-03-23 05:47 UTC, Peter Wemm 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Wemm freebsd_committer freebsd_triage 2015-03-23 05:45:28 UTC 
ports/devel/svk simply doesn't work with modern perl.

There are some simple changes that can be made to make it work.  We use these patches on the freebsd.org cluster underneath the socsvn repo.
Comment 1 Peter Wemm freebsd_committer freebsd_triage 2015-03-23 05:46:22 UTC 
Created attachment 154688 [details]
Patch for syntax error that traps on perl 5.18

This particular patch adds an extra set of ( ) to keep perl 5.18 happy.
Comment 2 Peter Wemm freebsd_committer freebsd_triage 2015-03-23 05:47:22 UTC 
Created attachment 154689 [details]
Patch to work around perl 5.16+

This patch worked around a svk explosion when the cluster moved to perl 5.16. I'm not sure it is the optimal patch, but it works.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-23 07:11:52 UTC 
No maintainer, Reporter is Committer. Assign accordingly.

Peter, can you create patches against the devel/svk port?

You can use `make makepatch` to create and name them automagically. Just:

make extract
cp WRKSRC/file WRKSRC/file.orig
make your edits
make makepatch

Then attach the svn diff here. 

Poudriere testport or bulk -t output would also be handy (as attachments)
Comment 4 Peter Wemm freebsd_committer freebsd_triage 2015-03-23 07:34:43 UTC 
Those are patch files against devel/svk, to be placed in files/* with appropriate names.  I pulled them straight out of the clusteradm poudriere build tree.

The current port builds fine, but fails at runtime and these two patches fix the runtime errors.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-23 07:46:54 UTC 
I'm happy to review and approve (enabling you to commit) a single diff against the ports tree rather than against the WRKSRC's, with poudriere output.

The only reason I suggested the `make makepatch` route is that file names and diffs would be correct based on the paths in WRKSRC (correct separators, etc).

If you'd like me to do that (and commit) instead, feel free to re-assign the issue to me and I'll take care of it. 

I thought you might enjoy committing to ports, given this was also a good candidate (no maintainer)
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-03-23 17:50:34 UTC 
A commit references this bug:

Author: peter
Date: Mon Mar 23 17:50:14 UTC 2015
New revision: 382017
URL: https://svnweb.freebsd.org/changeset/ports/382017

Log:
  Sustaining patches to make svk to work on newer perl.  This is in use
  on the FreeBSD.org cluster for historical reasons.

  PR:		198820

Changes:
  head/devel/svk/files/
  head/devel/svk/files/patch-lib_SVK_Mirror.pm
  head/devel/svk/files/patch-lib_SVK_Util.pm