Bug 199005 - devel/rubygem-listen: depend on devel/rubygem-rb-kqueue
Summary: devel/rubygem-listen: depend on devel/rubygem-rb-kqueue
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-29 18:25 UTC by Michael Moll
Modified: 2015-03-30 13:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
add dependency (659 bytes, patch)
2015-03-29 18:25 UTC, Michael Moll
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Moll freebsd_committer freebsd_triage 2015-03-29 18:25:45 UTC
Created attachment 154968 [details]
add dependency

The message generated in lib/listen/adapter/bsd.rb is recommending to install rb-kqueue on Dragonfly and FreeBSD, so I think it's a good idea to just depend on it. A test with jekyll serve --watch shows indeed lower CPU usage and faster respone times when changing a file.

If this is not wanted, I would change this PR to add a option for rb-kqueue and personally I'd enable it per default.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-03-30 13:48:11 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Mar 30 13:48:00 UTC 2015
New revision: 382663
URL: https://svnweb.freebsd.org/changeset/ports/382663

Log:
  - Use rb-kqueue instead of polling
  - Bump PORTREVISION for dependency change

  Reference:	https://github.com/guard/listen/blob/master/README.md#on-bsd
  PR:		199005
  Submitted by:	<kvedulv@kvedulv.de>

Changes:
  head/devel/rubygem-listen/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-03-30 13:50:44 UTC
Committed. Thanks!