Created attachment 155203 [details] patch: Disables TR1 support, converts to c++11 wxgtk30 uses the TR1 functions in its installed headers. These functions are not present in c++11 standard, and modern gcc (e.g. gcc4.9, gcc5) don't even recognized TR1 (gcc 4.7 did). The following patch forcibly removes TR1 functions, which requires the passing of -std=c++11 in the CXXFLAGS. This allows wxgtk30 headers to be used by latest gcc compilers. While here: - remove $PTHREAD_LIBS from configure. It wasn't populated, and the default of "-pthread" is fine - bring in dragonfly support from dports. TESTING: I used poudriere and built the following 62 ports before and after the patch was applied. These 62 ports are listed in INDEX-10 as requiring wxgtk30. The result was the same before and after: all 62 build successfully.
Created attachment 155204 [details] List of 62 ports built in poudriere This is the list of ports built in poudriere. These are the 62 primary ports -- on the first build with sanity checking, I ended up building 363 ports!
I'm looking for maintainer approval to commit the patch.
(In reply to John Marino from comment #2) > I'm looking for maintainer approval to commit the patch. Sorry for the delay, John. I'm afraid I didn't get the prior messages. I've examined your proposed patch. It looks good. Thanks for all the work you put into this! Please consider this reply, as "maintainer approval". Thanks again, John. --Chris
Thanks, all three messages were written within 3 minutes of each other.
(In reply to John Marino from comment #4) > Thanks, all three messages were written within 3 minutes of each other. I don't know about your Mondays. But mine seem to start off *really* busy. Which led to my having overlooked that small detail. :-) Thanks for taking to time to point that out, John, and thanks again, for all the work you did on this. --Chris
A commit references this bug: Author: marino Date: Mon Apr 6 18:49:54 UTC 2015 New revision: 383466 URL: https://svnweb.freebsd.org/changeset/ports/383466 Log: x11-toolkits/wxgtk30: Support c++11 over c++0x, plus DragonFly The wxgtk30 port will use TR1 headers if the capability is detected. These TR1 functions were experimental and not included in the same form in the final c++11 standard. This patch forcibly disabled TR1 support, which requires the explicit setting of -std=c++11 in CXXFLAGS> A private "exp-run" was performed, all 62 ports dependent on wxgtk2 successfully built before and after after the patch was applied on two separate runs (FreeBSD 10 amd64 jail). While here, remove the incorrect $PTHREAD_LIB setting and let it default to -pthread. Also bring in the configure patch fragement from DragonFly. PR: 199177 Submitted by: marino Approved by: maintainer (Chris Hutchinson) Changes: head/x11-toolkits/wxgtk30/Makefile head/x11-toolkits/wxgtk30/files/patch-configure head/x11-toolkits/wxgtk30/files/patch-setup.h.in
Here, Easter Monday is a holiday. :)
@John, @Jan Thanks for taking the time to create the reference. --Chris