Created attachment 155214 [details] Teach usb_libusb.c to use devices without serial number "adb devices" does not accept my old Huawei Ideos phone running CyanogenMod. It turns out it thinks it really needs a serial number on the USB interface. I wanted to submit this upstream, but it turns out somebody deleted the BSD support in AOSP master: https://android-review.googlesource.com/#/c/127904
Created attachment 157953 [details] Ignore non-ASCII languages Comparing with libusb code by hselasky for fastboot, working around serial number language may not be necessary. So, try the following patch instead. adb itself should accept empty serial just fine. https://android.googlesource.com/platform/system/core/+/c840653%5E!/ https://android.googlesource.com/platform/system/core/+/0927bf9%5E!/ $ adb devices List of devices attached ???????????? device or $ adb devices List of devices attached (no serial number) device
Kevin is the maintainer, so he should review the patch(es) -> assignee.
Ping. Can someone from usb@ help with review?
Hi, This patch belongs upstream. I'll to a more through review once they restore the libusb support. --HPS
(In reply to Hans Petter Selasky from comment #4) s/to/do
Will they?
Unlikely. usb_libusb.c was basically unmaintained, see my cleanup in ports r390138. My main gripe with working upstream are the following disrespectful requirments: - Sign up for Google Account (over Tor doesn't work) - Sign CLA to submit patches libusb backend in fastboot was abandoned by upstream as well. At least, it was in better shape. https://code.google.com/p/android/issues/detail?id=15749 https://svnweb.freebsd.org/ports/head/devel/android-tools-fastboot-devel/files/usb_freebsd.cpp
Assign to new maintainer after ports r398924. usb_libusb.cpp still needs more love, at least in -devel port e.g., try merging https://android.googlesource.com/platform/system/core/+/3d2904c%5E!/ https://android.googlesource.com/platform/system/core/+/812f030%5E!/
A commit references this bug: Author: jbeich Date: Wed Sep 28 09:43:39 UTC 2016 New revision: 422863 URL: https://svnweb.freebsd.org/changeset/ports/422863 Log: devel/android-tools-adb{,-devel}: drop unnecessary non-ASCII serial handling Linux replaced the code as well in https://android.googlesource.com/platform/system/core/+/9309ecbcec42%5E!/ PR: 199185 Changes: head/devel/android-tools-adb/Makefile head/devel/android-tools-adb/files/usb_libusb.cpp head/devel/android-tools-adb-devel/Makefile head/devel/android-tools-adb-devel/files/usb_libusb.cpp