Bug 199221 - [PATCH] audio/sooperlooper: Fix build on 8.x
Summary: [PATCH] audio/sooperlooper: Fix build on 8.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-06 18:40 UTC by tkato432
Modified: 2015-04-20 07:21 UTC (History)
1 user (show)

See Also:

Attachments
audio_sooperlooper.diff (1.12 KB, patch)
2015-04-06 18:40 UTC, tkato432 		no flags Details | Diff
audio_sooperlooper.diff (1.39 KB, patch)
2015-04-18 22:10 UTC, tkato432 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-04-06 18:40:03 UTC 
Created attachment 155259 [details]
audio_sooperlooper.diff
Comment 1 John Marino freebsd_committer freebsd_triage 2015-04-18 11:31:43 UTC 
actually, this doesn't currently build on FreeBSD 8.
It will work on FreeBSD 10.
Comment 2 tkato432 2015-04-18 22:10:33 UTC 
Created attachment 155709 [details]
audio_sooperlooper.diff

Here is the corrected patch.
Comment 3 John Marino freebsd_committer freebsd_triage 2015-04-20 06:55:17 UTC 
I don't think I like this approach.

1) Obviously it doesn't fix DragonFly
2) It doesn't fix the actual problem
3) If we downground to wx 2.8, I think all platforms should use 2.8.

another approach is to turn off the WXGTK option
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-04-20 07:19:48 UTC 
A commit references this bug:

Author: marino
Date: Mon Apr 20 07:19:34 UTC 2015
New revision: 384334
URL: https://svnweb.freebsd.org/changeset/ports/384334

Log:
  audio/sooperlooper: Unbreak on some platforms

  This unmaintained port is breaking on Wx 3.0, which is only an GUI option.
  Downgrading to Wx 2.8 allows it to build on all platforms (as well as
  having the option by default).  The second iteration of the PR suggested
  Wx3.0 for FreeBSD 8 and 9, but Wx  2.8 for F10+, but I didn't like that
  approach.  It only works on F8 and F9 because of compiler deficiencies.
  Simple attempts of setting -std to c++11 didn't work, of course.

  PR:		199221
  Submitted by:	ports fury

Changes:
  head/audio/sooperlooper/Makefile
Comment 5 John Marino freebsd_committer freebsd_triage 2015-04-20 07:21:20 UTC 
I went with the "2.8 everywhere" approach, thanks.