Bug 199339 - www/pound: Fix typo in PCRE_CONFIGURE_ENABLE, remove legacy MSDAV option
Summary: www/pound: Fix typo in PCRE_CONFIGURE_ENABLE, remove legacy MSDAV option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-10 01:39 UTC by ncrogers
Modified: 2015-04-10 16:45 UTC (History)
1 user (show)

See Also:

Attachments
www/pound/Makefile diff (963 bytes, patch)
2015-04-10 01:39 UTC, ncrogers 		no flags Details | Diff
poudriere testport log (56.48 KB, text/plain)
2015-04-10 01:39 UTC, ncrogers 		no flags Details
www/pound/Makefile diff (724 bytes, patch)
2015-04-10 01:43 UTC, ncrogers 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ncrogers 2015-04-10 01:39:01 UTC 
Created attachment 155400 [details]
www/pound/Makefile diff

Attached is a patch to fix a typo in www/pound PCRE_CONFIGURE_ENABLE directive. Also, I've removed the MSDAV option, as this is no longer a valid compiler flag in pound, for quite some time. Lastly, bump PORTREVISION.

I am the maintainer, but do not have commit access.

Also attached is poudriere testport output.
Comment 1 ncrogers 2015-04-10 01:39:37 UTC 
Created attachment 155401 [details]
poudriere testport log
Comment 2 ncrogers 2015-04-10 01:43:30 UTC 
Created attachment 155402 [details]
www/pound/Makefile diff
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-04-10 14:32:01 UTC 
A commit references this bug:

Author: danfe
Date: Fri Apr 10 14:31:01 UTC 2015
New revision: 383730
URL: https://svnweb.freebsd.org/changeset/ports/383730

Log:
  - Fix a typo in PCRE_CONFIGURE_ENABLE knob
  - Remove MSDAV option: this is no longer valid compiler flag in pound,
    for quite some time
  - Do not pass -I to CFLAGS, it is already added (correctly) to CPPFLAGS
  - Move initial CONFIGURE_ARGS after GNU_CONFIGURE where it logically belongs
  - Move OPTIONS and helper knobs right above .include <bsd.port.options.mk>
  - Remove ".if ${PORT_OPTIONS:MDOCS}" guard, not needed in post-staging
  - Slightly beautify files/pound.in and pkg-descr while I'm here

  PR:		199339
  Submitted by:	maintainer

Changes:
  head/www/pound/Makefile
  head/www/pound/files/pound.in
  head/www/pound/pkg-descr
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-10 14:33:05 UTC 
Committed as ports r383730 with minor modification, thank you!
Comment 5 ncrogers 2015-04-10 16:45:56 UTC 
(In reply to Alexey Dokuchaev from comment #4)

Thanks! And thank you for the extra cleanup.