Bug 199612 - [maintainer-update] graphics/optipng: Update to 0.7.5
Summary: [maintainer-update] graphics/optipng: Update to 0.7.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 14:14 UTC by Thomas Hurst
Modified: 2015-04-23 11:12 UTC (History)
0 users

See Also:


Attachments
patch to 0.7.5 (3.96 KB, patch)
2015-04-22 14:14 UTC, Thomas Hurst
tom: maintainer-approval+
Details | Diff
poudriere testport on 10.1-RELEASE/amd64 (83.63 KB, text/plain)
2015-04-22 14:15 UTC, Thomas Hurst
no flags Details
poudriere testport on 9.3-RELEASE/amd64 (83.83 KB, text/plain)
2015-04-22 14:15 UTC, Thomas Hurst
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hurst 2015-04-22 14:14:53 UTC
Created attachment 155855 [details]
patch to 0.7.5

Update to 0.7.5.

Convert to modern OPTIONS style.  Had to use _CONFIGURE_ON/_OFF due to lack of _CONFIGURE_WITHOUT - better than breaking existing configs.

Fix a compiler warning on amd64 - pngxmem.c is expected to compare height with MAX_UINT / sizeof(*ptr), but was instead doing MAX_ULONG / sizeof(*ptr).  It should now correctly reject PNGs more than 536.8 million pixels tall.  I don't have one handy to test :(
Comment 1 Thomas Hurst 2015-04-22 14:15:27 UTC
Created attachment 155856 [details]
poudriere testport on 10.1-RELEASE/amd64
Comment 2 Thomas Hurst 2015-04-22 14:15:46 UTC
Created attachment 155857 [details]
poudriere testport on 9.3-RELEASE/amd64
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-04-23 11:11:42 UTC
Committed. Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-04-23 11:12:12 UTC
A commit references this bug:

Author: jbeich
Date: Thu Apr 23 11:11:13 UTC 2015
New revision: 384558
URL: https://svnweb.freebsd.org/changeset/ports/384558

Log:
  - Update to 0.7.5
  - Convert to option helpers but don't use _CONFIGURE_WITH
    due to inverse logic
  - Fix compiler warning on amd64 due to (size_t)(-1)
    being larger than UINT_MAX

  PR:		199612
  Submitted by:	Thomas Hurst <tom@hur.st> (maintainer)

Changes:
  head/graphics/optipng/Makefile
  head/graphics/optipng/distinfo
  head/graphics/optipng/files/patch-src-optipng-osys.c
  head/graphics/optipng/files/patch-src_optipng_osys.c
  head/graphics/optipng/files/patch-src_pngxtern_pngxmem.c