Bug 199649 - [PATCH] lang/erlang: fix sendfile
Summary: [PATCH] lang/erlang: fix sendfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jimmy Olgeni
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-23 19:19 UTC by Stefan Grundmann
Modified: 2015-04-24 13:16 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olgeni)

Attachments
fix sendfile in lang/erlang (1.02 KB, patch)
2015-04-23 19:19 UTC, Stefan Grundmann 		no flags Details | Diff
fix sendfile in lang/erlang-runtime17 (1.16 KB, patch)
2015-04-23 19:20 UTC, Stefan Grundmann 		no flags Details | Diff
fix sendfile in lang/erlang-runtime16 (1.16 KB, patch)
2015-04-23 19:21 UTC, Stefan Grundmann 		no flags Details | Diff
fix sendfile in lang/erlang-runtime15 (1.88 KB, patch)
2015-04-23 19:21 UTC, Stefan Grundmann 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Grundmann 2015-04-23 19:19:29 UTC 
Created attachment 155920 [details]
fix sendfile in lang/erlang

erlang file:sendfile/2,5 is broken on FreeBSD,
commit message in erlang OTP upstream pull request 

  https://github.com/erlang/otp/pull/694 

explains the issue.

minimal testcase:

  https://gist.github.com/sg2342/669c896afbd12626366c
Comment 1 Stefan Grundmann 2015-04-23 19:20:38 UTC 
Created attachment 155921 [details]
fix sendfile in lang/erlang-runtime17
Comment 2 Stefan Grundmann 2015-04-23 19:21:22 UTC 
Created attachment 155922 [details]
fix sendfile in lang/erlang-runtime16
Comment 3 Stefan Grundmann 2015-04-23 19:21:57 UTC 
Created attachment 155923 [details]
fix sendfile in lang/erlang-runtime15
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-04-24 13:15:16 UTC 
A commit references this bug:

Author: olgeni
Date: Fri Apr 24 13:15:03 UTC 2015
New revision: 384637
URL: https://svnweb.freebsd.org/changeset/ports/384637

Log:
  Fix implementation of sendfile function on FreeBSD.

  Also, replace USE_AUTOTOOLS with USES=autoreconf while I'm here.

  PR:		199649
  Submitted by:	Stefan Grundmann

Changes:
  head/lang/erlang/Makefile
  head/lang/erlang/files/patch-erts_emulator_drivers_common_efile__drv.c
  head/lang/erlang-runtime15/Makefile
  head/lang/erlang-runtime15/files/patch-erts_emulator_drivers_common_efile__drv.c
  head/lang/erlang-runtime16/Makefile
  head/lang/erlang-runtime16/files/patch-erts_emulator_drivers_common_efile__drv.c
  head/lang/erlang-runtime17/Makefile
  head/lang/erlang-runtime17/files/patch-erts_emulator_drivers_common_efile__drv.c
Comment 5 Jimmy Olgeni freebsd_committer freebsd_triage 2015-04-24 13:16:45 UTC 
Fix committed to all Erlang ports. Thank you!