Bug 199657 - [PATCH] irc/bitlbee: Enable Skype module / use OPTIONS helpers
Summary: [PATCH] irc/bitlbee: Enable Skype module / use OPTIONS helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-24 08:41 UTC by Bernard Spil
Modified: 2015-05-07 19:38 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
svn diff for irc/bitlbee (3.15 KB, patch)
2015-04-24 08:43 UTC, Bernard Spil 		no flags Details | Diff
svn diff for irc/bitlbee (3.67 KB, patch)
2015-04-24 09:38 UTC, Bernard Spil 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2015-04-24 08:41:42 UTC 
A user on IRC was asking about Skype support in bitlbee. This is not currently configurable in the port so I modified the port.

1. Add option for Skype, modify plist
2. Replace PORT_OPTION conditionals with OPTIONS helpers
3. Do not set options for configure's default options
4. Re-order options alphabetically
5. libevent wasn't detected, added --libevent=${PREFIX}

Have not been running bitlbee for quite a while so this is not tested at runtime.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2015-04-24 08:43:22 UTC 
Created attachment 155940 [details]
svn diff for irc/bitlbee
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2015-04-24 09:38:16 UTC 
Created attachment 155942 [details]
svn diff for irc/bitlbee

Adds missing dependency on py-skype4py
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-05-07 19:37:43 UTC 
A commit references this bug:

Author: garga
Date: Thu May  7 19:36:51 UTC 2015
New revision: 385656
URL: https://svnweb.freebsd.org/changeset/ports/385656

Log:
  - Add a new SKYPE option, off by default
  - Modernize Makefile using OPTION helpers
  - Do not set options for configure's default options
  - Re-order options alphabetically
  - libevent wasn't detected, added --libevent=${PREFIX}

  PR:		199657 (based on)
  Submitted by:	Bernard Spil <spil.oss@gmail.com>

Changes:
  head/irc/bitlbee/Makefile
  head/irc/bitlbee/pkg-plist