Bug 199682 - science/libkml: don't bundle liburiparser
Summary: science/libkml: don't bundle liburiparser
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-25 09:39 UTC by Mathieu Arnold
Modified: 2015-04-28 17:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
libkml.diff (8.18 KB, patch)
2015-04-25 09:39 UTC, Mathieu Arnold 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2015-04-25 09:39:00 UTC 
Created attachment 155968 [details]
libkml.diff

libkml bundles liburiparser for the sole reason of:

There are two local modifications to the uriparser code to avoid compiler
warnings on some recent flavors of GCC. Diff these revisions for details:
r706 : r705 (strict initialization)
r714 : r713 (free called on const pointer)

As it conflicts with our own liburiparser, make libkml depend, and use our net/uriparser.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2015-04-25 10:23:01 UTC 
Also, this needs a PORTREVISION bump.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-04-28 17:51:46 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Apr 28 17:50:45 UTC 2015
New revision: 384927
URL: https://svnweb.freebsd.org/changeset/ports/384927

Log:
  - Use net/uriparser instead of bundled one
  - Bump PORTREVISION for dependency and package change

  PR:		199682 (based on)
  Submitted by:	mat

Changes:
  head/science/libkml/Makefile
  head/science/libkml/files/patch-src-kml-base-Makefile.am
  head/science/libkml/files/patch-src-swig-Makefile.am
  head/science/libkml/files/patch-third_party-Makefile.am
  head/science/libkml/pkg-plist
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-04-28 17:56:46 UTC 
Committed. Thanks!