Bug 199717 - devel/libublio: missing .pc file
Summary: devel/libublio: missing .pc file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-26 19:12 UTC by resver
Modified: 2016-05-26 08:04 UTC (History)
1 user (show)

See Also:


Attachments
.pc file (232 bytes, text/plain)
2015-04-26 19:12 UTC, resver
mandree: maintainer-approval-
Details
.pc.in file (239 bytes, text/plain)
2015-04-30 20:09 UTC, resver
no flags Details
Proposed patch (since 415750 revision) (490 bytes, patch)
2016-05-24 04:28 UTC, lightside
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description resver 2015-04-26 19:12:29 UTC
Created attachment 156015 [details]
.pc file

Hi,

pkg-config significantly simplifies use of libraries (especially for projects that use autotools) but requires appropriate .pc file describing the library. Please add the attached .pc file to the libublio port.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2015-04-28 06:18:25 UTC
Comment on attachment 156015 [details]
.pc file

That file won't work. We need to substitute ${PREFIX} and other directories into the file properly. Please send a suitable ublio.pc.in file that gets the necessary variable substitutions from the ports build framework.  In doubt, see the FreeBSD porter's handbook for help.
Comment 2 resver 2015-04-30 20:09:39 UTC
Created attachment 156163 [details]
.pc.in file

Thanks for the hint. Here is the .pc.in file.
Comment 3 resver 2015-05-22 07:01:18 UTC
Ping.

Could you please review the attached file?
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2016-05-23 22:43:29 UTC
Sorry about the long delay, I'd missed the update and the ping in a mail flood.
I have committed a .pc file change but it's called libublio for now to match the port name - what do users expect?  

Feel free to reopen the bug and name/list a few ports that require ublio (not libublio).
Comment 5 lightside 2016-05-24 04:28:20 UTC
Created attachment 170586 [details]
Proposed patch (since 415750 revision)

Hello Matthias Andree.

(In reply to comment #4)
> I have committed a .pc file change but it's called libublio for now to match
> the port name - what do users expect?

Looks like, you didn't "svn add files/libublio.pc.in" in SVN repository (relative to devel/libublio directory).
Other people commented about it (bug 199797 comment 5) in your (incorrectly) specified PR 199797.

Attached patch with proposed changes, just for reference.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-05-24 06:19:26 UTC
A commit references this bug:

Author: mandree
Date: Tue May 24 06:19:02 UTC 2016
New revision: 415764
URL: https://svnweb.freebsd.org/changeset/ports/415764

Log:
  Really add .pc file for devel/libublio.

  (I wish that poudriere or a make under DEVELOPER=yes would use
  svn export to actually check for missing files.)

  PR:		199717
  Reported by:	Barbara Guida, lightside

Changes:
  head/devel/libublio/Makefile
  head/devel/libublio/files/libublio.pc.in
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2016-05-26 08:04:08 UTC
-- for reference, this original comment got misfiled through my typo, I am copying it here just to have a complete trail in the right PR, this was the earlier, incomplete, commit (see the Date:) --

A commit references this bug:

Author: mandree
Date: Mon May 23 22:42:04 UTC 2016
New revision: 415750
URL: https://svnweb.freebsd.org/changeset/ports/415750

Log:
  Add pkgconfig file. Add LICENSE clause.

  PR:		199797
  Submitted by:	resver@gmail.com

Changes:
  head/devel/libublio/Makefile
  head/devel/libublio/pkg-plist