It's a native build running FreeBSD 11.0-CURRENT #0 r282366M on a Wandboard-Quad. --- Toolbar.o --- Toolbar.cc:47:11: error: no matching function for call to 'max' return (std::max(1000l, ((((resolution - (now.tv_sec % resolution)) * 1000l)) ^~~~~~~~ /usr/include/c++/v1/algorithm:2654:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('long' vs. 'long long') max(const _Tp& __a, const _Tp& __b) ^ /usr/include/c++/v1/algorithm:2646:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided max(const _Tp& __a, const _Tp& __b, _Compare __comp) ^ 1 error generated. *** [Toolbar.o] Error code 1 make[3]: stopped in /usr/local/DEVEL/ports/x11-wm/blackbox/work/blackbox-0.70.1/src --- Window.o --- Window.cc:3524:14: warning: '&&' within '||' [-Wlogical-op-parentheses] && (event->state & Button1Mask ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Window.cc:3524:14: note: place parentheses around the '&&' expression to silence this warning && (event->state & Button1Mask ^ 1 warning generated. 1 error make[3]: stopped in /usr/local/DEVEL/ports/x11-wm/blackbox/work/blackbox-0.70.1/src *** [all-recursive] Error code 1
Created attachment 156657 [details] fix armv6 build Can you try the attached patch?
The patch doesn't work. I think, it's because of the suffix '.orig' of files/extra-patch-src_Toolbar.cc.orig? => SHA256 Checksum OK for blackbox-0.70.1.tar.gz. ===> Patching for blackbox-0.70.1_4 ===> Applying extra patch /usr/local/DEVEL/ports/x11-wm/blackbox/files/extra-patch-src_Toolbar.cc cat: /usr/local/DEVEL/ports/x11-wm/blackbox/files/extra-patch-src_Toolbar.cc: No such file or directory I can't seem to find a patch in there anywhere. *** Error code 2
ls files/* shows: extra-patch-src_Toolbar.cc.orig extra-patch-src_Toolbar.cc.orig.orig ... If I do: mv extra-patch-src_Toolbar.cc.orig extra-patch-src_Toolbar.cc the build finished sucessfully and blackbox works! Thank you for the patch.
Created attachment 156659 [details] correct previous patch
Thank you, Ulrich and Mikael.
(In reply to mikael.urankar from comment #4) I can confirm that this patch does, in fact, correct the issue, which I also encountered verbatim just a few minutes ago.
A commit references this bug: Author: mmoll Date: Sun Nov 29 21:53:13 UTC 2015 New revision: 402631 URL: https://svnweb.freebsd.org/changeset/ports/402631 Log: x11-wm/blackbox: fix build on arm PR: 200124 Submitted by: Mikael Urankar <mikael.urankar@gmail.com> Approved by: maintainer (timeout) Changes: head/x11-wm/blackbox/Makefile head/x11-wm/blackbox/files/extra-patch-src_Toolbar.cc
commited, thanks!
Assign to committer that resolved. @Michael, should this be merged (MFH) to the quarterly branch? I believe this change would come under blanket approval.
It could be MFHed under the "fixes build" blanket, but I'm unsure if this port is really widely used, especially on arm, so I don't know if that's justified.
It's very rarely used, unmaintained for a decade this month, effectively abandoned at SourceForge* and almost no-one looks for support including contacting me or asking on #blackbox on FreeNode IRC. On the other hand, there is an community supported Arch Linux package for Arm[1]. Developer Brad Hughes has moved it to GitHub[2] and has updated some files since the last release, but AFAIK is not developing it or planning another release. [1] http://archlinuxarm.org/packages?arch=&search=blackbox [2] https://github.com/bradleythughes/blackbox
IMHO it would be super helpful then, if you could submit the rest of the patches (if there are any) to the github repo and change the port to USE_GITHUB. But I also have no problem with the current situation. :)
If blackbox is resurrected from its decade-long slumber and there's a new release, then I'll update the port accordingly, but until then there's no clear advantage.
Personally I'm always glad to delete patches from our ports tree, but as said, the current situation is also fine. As the impact is rather small, not MFHing and closing again.