Bug 200155 - textproc/p5-Unicode-LineBreak - Support for libthai
Summary: textproc/p5-Unicode-LineBreak - Support for libthai
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 17:36 UTC by Andres Montalban
Modified: 2015-06-10 18:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (Olivier.Girard)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Montalban 2015-05-12 17:36:18 UTC 
Hi,

It's possible to remove the "--disable-libthai" line so we can have libthai support? Any reason that this option is configured?

I have tried to rebuild the port without this option and works ok in my environment.

Thank you!
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-21 17:06:55 UTC 
This should be optional though.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-05-27 03:13:18 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed May 27 03:12:36 UTC 2015
New revision: 387536
URL: https://svnweb.freebsd.org/changeset/ports/387536

Log:
  - Add optional libthai support

  PR:		200155
  Submitted by:	amontalban@gmail.com
  Approved by:	maintainer timeout (Olivier.Girard@univ-angers.fr, 2 weeks)

Changes:
  head/textproc/p5-Unicode-LineBreak/Makefile
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-27 03:32:06 UTC 
Please test
Comment 4 Andres Montalban 2015-05-27 03:35:35 UTC 
(In reply to Dmitry Marakasov from comment #3)

Great thank you! I will test this tomorrow and let you guys know.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-28 09:32:19 UTC 
Also I wonder if this should be enabled by default. The rule of thumb is to tune default options so the package is useful for most users even if this brings some extra depends. Waiting a week more on this for possible maintainer feedback.
Comment 6 Andres Montalban 2015-05-28 13:26:57 UTC 
Hi Dmitry,

I have tested and it builds great.

Regarding the default option I do not know the guidelines, but I'm ok with current functionality.

Thanks!
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-10 18:12:44 UTC 
libthai support enabled by default
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-06-10 18:12:48 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Jun 10 18:12:36 UTC 2015
New revision: 389120
URL: https://svnweb.freebsd.org/changeset/ports/389120

Log:
  - Enable thai support by default

  PR:		200155
  Submitted by:	amontalban@gmail.com
  Approved by:	maintainer timeout (Olivier.Girard@univ-angers.fr, 4 weeks)

Changes:
  head/textproc/p5-Unicode-LineBreak/Makefile