Bug 200260 - sysutils/zfs-stats-lite: printf formatting error
Summary: sysutils/zfs-stats-lite: printf formatting error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Devin Teske
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-17 01:40 UTC by Joseph Mingrone
Modified: 2015-09-15 16:55 UTC (History)
2 users (show)

See Also:
jrm: maintainer-feedback+

Attachments
Escape a '%' character in a printf statement. (372 bytes, patch)
2015-05-17 01:40 UTC, Joseph Mingrone 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2015-05-17 01:40:47 UTC 
Created attachment 156846 [details]
Escape a '%'  character in a printf statement.

I believe there is a typo on lines 745-726 of the script.

Should

printf "\t  Sent Total:\t\t\t%0.2f%\t%d\n" 100 \
       $l2_writes_sent

be

printf "\t  Sent Total:\t\t\t%0.2f%%\t%d\n" 100 \
       $l2_writes_sent

?
Comment 1 Mark Felder freebsd_committer freebsd_triage 2015-07-28 18:15:57 UTC 
I don't want to patch within the ports tree if Devin can just take this fix and roll a new release. He may have lost the email.
Comment 2 Ed Maste freebsd_committer freebsd_triage 2015-08-04 20:33:06 UTC 
Can you confirm that this was observed on arm64?
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2015-08-04 20:36:50 UTC 
No, this was observed on amd64. I update the hardware field.
Comment 5 Devin Teske freebsd_committer freebsd_triage 2015-09-14 16:55:44 UTC 
https://reviews.freebsd.org/D3663
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-09-15 16:38:50 UTC 
A commit references this bug:

Author: dteske
Date: Tue Sep 15 16:38:47 UTC 2015
New revision: 397004
URL: https://svnweb.freebsd.org/changeset/ports/397004

Log:
  Bump to version 1.2: fix printf formatting error

  PR:		ports/200260
  Differential Revision:	https://reviews.freebsd.org/D3663
  Submitted by:	Joseph Mingrone <jrm@ftfl.ca>
  Reviewed by:	feld
  Approved by:	feld

Changes:
  head/sysutils/zfs-stats-lite/Makefile
  head/sysutils/zfs-stats-lite/distinfo
Comment 7 Devin Teske freebsd_committer freebsd_triage 2015-09-15 16:55:20 UTC 
Committed as SVN r397004:
https://svnweb.freebsd.org/ports?view=revision&revision=397004