Bug 200561 - [patch] sysutils/b2sum: add options, take maintainership
Summary: [patch] sysutils/b2sum: add options, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-01 02:28 UTC by Matthew Rezny
Modified: 2015-06-01 22:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
sysutils/b2sum improvements (3.13 KB, patch)
2015-06-01 02:28 UTC, Matthew Rezny 		no flags Details | Diff
sysutils/b2sum improvements v2 (3.11 KB, patch)
2015-06-01 12:14 UTC, Matthew Rezny 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2015-06-01 02:28:53 UTC 
Created attachment 157321 [details]
sysutils/b2sum improvements

Improve sysutils/b2sum:
Make SSE2+ instructions optinal (default ON for amd64, can be used on some i386) to alow buiding on any platform
Add OpenMP option
Patch to not crash when compiled with Clang

Taking over as maintainer after it was offered on IRC.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2015-06-01 04:54:59 UTC 
Looks good, but why building static?
Comment 2 Matthew Rezny freebsd_committer freebsd_triage 2015-06-01 12:14:02 UTC 
Created attachment 157341 [details]
sysutils/b2sum improvements v2
Comment 3 Matthew Rezny freebsd_committer freebsd_triage 2015-06-01 12:16:10 UTC 
(In reply to Baptiste Daroussin from comment #1)

That was copied from the original makefile while making all other CFLAGS into options. Now that you ask, I can't think of any good reason to static link. I tested without and there is no difference in functionality or performance. So, refreshed patch without that.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-06-01 22:01:59 UTC 
A commit references this bug:

Author: bapt
Date: Mon Jun  1 22:01:54 UTC 2015
New revision: 388290
URL: https://svnweb.freebsd.org/changeset/ports/388290

Log:
  Improve sysutils/b2sum:

  Make SSE2+ instructions optinal (default ON for amd64, can be used on some i386)
  to alow buiding on any platform
  Add OpenMP option
  Patch to not crash when compiled with Clang

  Pass maintainership to submitter
  Bump portrevision

  PR:		200561
  Submitted by:	matthew@reztek.cz

Changes:
  head/sysutils/b2sum/Makefile
  head/sysutils/b2sum/files/
  head/sysutils/b2sum/files/patch-blake2.h
  head/sysutils/b2sum/files/use_ref.patch