Bug 200575 - net-mgmt/nagiosql: add cpe, NO_ARCH, modernize plist
Summary: net-mgmt/nagiosql: add cpe, NO_ARCH, modernize plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-01 17:46 UTC by Dmitry Marakasov
Modified: 2015-06-27 19:39 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chris)

Attachments
Patch (6.99 KB, patch)
2015-06-01 17:46 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-01 17:46:38 UTC 
Created attachment 157349 [details]
Patch

- Add CPE info
- Add NO_ARCH
- Modernize plist

what bugs me is that poudriere testport reports modified directory permissions:

...
====>> Checking for extra files and directories
====>> Error: Files or directories modified:
/var/spool/%%NAGIOSUSER%% permissions (0775, 0755)
build of net-mgmt/nagiosql ended at Mon Jun  1 20:08:21 MSK 2015
build time: 00:00:12
!!! build failure encountered !!!
...

however nagiosql does not touch this directory at all, so it may be unrelated problem.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-01 17:47:03 UTC 
CC mat@ as nagios maintainer.
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2015-06-01 21:01:20 UTC 
net-mgmt/nagiosql depends on nagios and nagios owns /var/spool/nagios, so you can ignore the directory.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-01 23:30:42 UTC 
> net-mgmt/nagiosql depends on nagios and nagios owns /var/spool/nagios, so you can ignore the directory.

That's what I thought as well, however this message should indicate a problem elsewhere.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2015-06-02 05:19:00 UTC 
(In reply to Dmitry Marakasov from comment #3)
> > net-mgmt/nagiosql depends on nagios and nagios owns /var/spool/nagios, so you can ignore the directory.
> 
> That's what I thought as well, however this message should indicate a
> problem elsewhere.

I'm not sure why you are adding me back to the CC here ? Do you want me to debug the problem you are having with a port that is not mine ?
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-02 13:54:45 UTC 
(In reply to Mathieu Arnold from comment #4)
> I'm not sure why you are adding me back to the CC here ? Do you want me to debug the problem you are having with a port that is not mine ?

As you've mentioned, the directory from error report is owned by nagios which is yours. I suspect the problem is there.
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2015-06-26 20:29:41 UTC 
Take.
Comment 7 Philip M. Gollucci freebsd_committer freebsd_triage 2015-06-27 03:38:20 UTC 
Maintainer Timeout - 26 days (chris@smartt.com)
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-06-27 19:31:47 UTC 
A commit references this bug:

Author: pgollucci
Date: Sat Jun 27 19:31:20 UTC 2015
New revision: 390723
URL: https://svnweb.freebsd.org/changeset/ports/390723

Log:
  net-mgmt/nagiosql: modernize

  - add cpe,
  - set NO_ARCH
  - modernize plist

  PR:                  200575
  Submitted by:        amdmi3@FreeBSD.org
  Approved by:         maintainer timeout (chris@smartt.com ; 26 days)

Changes:
  head/net-mgmt/nagiosql/Makefile
  head/net-mgmt/nagiosql/pkg-plist