Bug 200586 - [PATCH] devel/luafilesystem use base system make
Summary: [PATCH] devel/luafilesystem use base system make
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-06-02 05:04 UTC by Timothy Beyer
Modified: 2015-11-06 20:41 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (fiziologus)

Attachments
simple patch for luafilesystem (1.19 KB, patch)
2015-06-02 05:04 UTC, Timothy Beyer 		no flags Details | Diff
New patch with fix (1.07 KB, patch)
2015-07-19 19:04 UTC, fiziologus 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2015-06-02 05:04:06 UTC 
Created attachment 157365 [details]
simple patch for luafilesystem

This patch adjusts files/patch-Makefile such that BSD make works correctly.

As a result, GNU make is no longer required.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2015-06-27 11:32:33 UTC 
This causes build failure on amd64:

=======================<phase: build          >============================
===>  Building for lua52-luafilesystem-1.6.3
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -O2 -Wall -fPIC -W -Waggregate-return -Wcast-align -Wmissing-prototypes -Wnested-externs -Wshadow -Wwrite-strings -pedantic -I/usr/local/include/lua52 -c src/lfs.c -o src/lfs.o
mv lfs.o src/
mv: lfs.o: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/devel/luafilesystem/work/luafilesystem-v_1_6_3
*** Error code 1
Comment 2 fiziologus 2015-06-30 00:41:18 UTC 
(In reply to Thomas Zander from comment #1)
This build system error (or your ports tree mirror incorect).

===>  Building for lua52-luafilesystem-1.6.3
--- src/lfs.o ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -O2 -Wall -fPIC -W -Waggregate-return -Wcast-align -Wmissing-prototypes -Wnested-externs -Wshadow -Wwrite-strings -pedantic -I/usr/local/include/lua52 -c src/lfs.c
--- src/lfs.so ---
cc -O2 -pipe  -fstack-protector -fno-strict-aliasing   -O2 -Wall -fPIC -W -Waggregate-return -Wcast-align -Wmissing-prototypes -Wnested-externs -Wshadow -Wwrite-strings -pedantic -I/usr/local/include/lua52 -shared -o src/lfs.so src/lfs.o

'-o' flag not use default (in port for object file build use default scheme '$CC $CFLAGS -c $SOURCE', defined only lib compile rules).
Comment 3 Timothy Beyer 2015-06-30 06:49:29 UTC 
It is building differently on my ports tree, I'll look into why that is the case.

I'll see if redports is available again to test on external machines.
Comment 4 fiziologus 2015-07-19 19:04:37 UTC 
Created attachment 158976 [details]
New patch with fix

Some modify patch. Added hardcoding for object file files (avoid difference rules in port's tree and build system).
Comment 5 Timothy Beyer 2015-07-21 03:27:21 UTC 
The patch submitted by fiziologus@gmail.com works correctly on my system.

It looks more general than my patch or the original, so it is unlikely to have compatibility issues.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-11-06 20:41:35 UTC 
A commit references this bug:

Author: pawel
Date: Fri Nov  6 20:40:35 UTC 2015
New revision: 400958
URL: https://svnweb.freebsd.org/changeset/ports/400958

Log:
  - Allow build without using gmake [1]
  - Regenerate patches

  PR:		200586 [1]
  Submitted by:	maintainer and Timothy Beyer [1]

Changes:
  head/devel/luafilesystem/Makefile
  head/devel/luafilesystem/files/patch-Makefile
  head/devel/luafilesystem/files/patch-config