Bug 200728 - science/hdf5: drop not working thread support
Summary: science/hdf5: drop not working thread support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-09 09:06 UTC by fmysh
Modified: 2015-06-10 16:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch for Makefile (360 bytes, patch)
2015-06-09 09:06 UTC, fmysh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fmysh 2015-06-09 09:06:42 UTC 
Created attachment 157561 [details]
patch for Makefile

1. A configure flag --with-pthread is valid only when --enable-threadsafe is specified. Single --with-pthread has no effect.

2. The configure flag --enable-threadsafe is incompatible with --enable-cxx or --enable-fortran.

As we use --enable-{cxx,fortran}, remove the not working thread support, --with-pthread=/usr from CONFIGURE_ARGS.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-06-10 16:48:35 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Jun 10 16:47:44 UTC 2015
New revision: 389075
URL: https://svnweb.freebsd.org/changeset/ports/389075

Log:
  - Remove no-op --with-pthread=/usr from CONFIGURE_ARGS:
    - --enable-threadsafe and --enable-cxx/--enable-cxx are mutually exclusive
    - --with-pthread=/usr is only valid with --enable-threadsafe

  PR:		200728
  Submitted by:	Taoka Fumiyoshi <fmysh@iijmio-mail.jp>

Changes:
  head/science/hdf5/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-06-10 16:56:29 UTC 
Committed. Thanks!