Created attachment 157745 [details] patch for qTox
Created attachment 157746 [details] patch for toxcore
Created attachment 157747 [details] patch for libfilteraudio
Please note that toxcore had redundant dependencies multimedia/libv4l and multimedia/ffmpeg - I removed them.
Created attachment 157748 [details] poudriere log
Created attachment 157749 [details] patch for qTox
Created attachment 157754 [details] patch for qTox
Hi Yuri, can you please: * Create a separate issue for net-im/tox (with QA attachments) so that the maintainer can be assigned to resolve it independently * Once created, have this issue "depend on" the newly created issue (Use the "Depends on" field) * Obsolete attachments in this issue that relate to net-im/tox
Hi Kubilay, These ports are closely related, and should be updated together and frequently (because they are also developed rapidly). Usually thierry@ was committing them together. Yuri
I understand that they may need to be committed together, but that does not in itself preclude creating separate issues for the changes. The be clear, the main reasons for needing this is to: * Clearly establish the responsibility for each change, given that Thierry is the maintainer for one (and only one) of the changes being requested. * Ensure that if the maintainer cannot respond or resolve the dependency changes needed in a timely manner, that someone else may resolve it. As it stands now with all of the changes in a single issue, and with multiple persons responsible for action, there is nothing that can be used (ie; a maintainer timeout) to compel a change without approval.
There is a problem with the submitted patches: as usual, the API changed, and now uTox (and toxic) are broken. Not a real problem for toxic, and I add a patch to upgrade it. For uTox, the messages are: CC friend.o tox.c:546:48: error: too many arguments to function call, expected 2, have 4 if((tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL) { ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~ /usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error); ^ tox.c:548:118: error: too many arguments to function call, expected 2, have 4 if(!options.proxy_type || (options.proxy_type = TOX_PROXY_TYPE_NONE, (tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL)) { ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~ /usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error); ^ tox.c:550:108: error: too many arguments to function call, expected 2, have 4 if(!options.ipv6_enabled || (options.ipv6_enabled = 0, (tox = tox_new(&options, save_data, save_size, &tox_new_err)) == NULL)) { ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~ /usr/local/include/tox/tox.h:615:1: note: 'tox_new' declared here Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error); Ivan, could you please check if refreshing uTox is sufficient?
Created attachment 157767 [details] patch for toxic Patch to upgrade net-im/toxic and chase the new toxcore.
(In reply to Kubilay Kocak from comment #9) koobs, I approve the submitted patch for my port, and I have taken this PR.
Thierry, uTox builds for me with upstream rev.5a5132f.
Created attachment 157793 [details] Suggested uTox patch uTox patch that works for me.
(In reply to yuri from comment #14) Thanks! Waiting for fidaj's approval.
Created attachment 157860 [details] patch-uTox.me.variant Some minor fixes.
At first glance, no problems found.
A commit references this bug: Author: thierry Date: Thu Jun 18 19:50:58 UTC 2015 New revision: 390058 URL: https://svnweb.freebsd.org/changeset/ports/390058 Log: Upgrade Tox, libfilteraudio, toxic, qTox and uTox to a recent snapshot. PR: ports/200865 Submitted by: yuri (at) rawbw.com (qTox maintainer) + patches from other maintainers Approved by: maintainers Changes: head/audio/libfilteraudio/Makefile head/audio/libfilteraudio/distinfo head/net-im/qTox/Makefile head/net-im/qTox/distinfo head/net-im/qTox/files/patch-qtox.pro head/net-im/qTox/files/patch-src_main.cpp head/net-im/qTox/files/patch-src_platform_camera_v4l2.cpp head/net-im/qTox/files/patch-src_platform_camera_v4l2.h head/net-im/tox/Makefile head/net-im/tox/distinfo head/net-im/toxic/Makefile head/net-im/toxic/distinfo head/net-im/uTox/Makefile head/net-im/uTox/distinfo head/net-im/uTox/files/patch-Makefile
Note to Yuri: since you replaced libtoxcore.a by libtoxcore.so, qTox cannot be built if toxcore depends on NaCl; is this necessary?
> Note to Yuri: since you replaced libtoxcore.a by libtoxcore.so, qTox cannot be > built if toxcore depends on NaCl; is this necessary? Thierry, Thanks for noting this. I will review this for the next update, and if necessary will discuss it with you then. Thanks! Yuri