Bug 200924 - audio/wavegain: mark ONLY_FOR_ARCHS, simplify
Summary: audio/wavegain: mark ONLY_FOR_ARCHS, simplify
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-16 23:40 UTC by Dmitry Marakasov
Modified: 2015-07-01 17:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (darcsis)

Attachments
Patch (1.56 KB, patch)
2015-06-16 23:41 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:40:57 UTC 
- Mark ONLY_FOR_ARCHS=i386 amd64, as it uses x86 assembly. There's only single function (lrint), and it is possible that libc lrint(3) may be used instead, thus removing this limitation. Would be nice for maintainer to check that possibility.
- Simplify build: instead of copying, then patching, then patching again with REINPLACE_CMD the Makefile, just run one-line build command used in it directly
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-16 23:41:43 UTC 
Created attachment 157818 [details]
Patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-01 17:24:41 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Jul  1 17:23:53 UTC 2015
New revision: 391081
URL: https://svnweb.freebsd.org/changeset/ports/391081

Log:
  - Mark ONLY_FOR_ARCHS, uses x86 assembly
  - Simplify Makefile

  PR:		200924
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (darcsis@gmail.com, 2 weeks)

Changes:
  head/audio/wavegain/Makefile
  head/audio/wavegain/files/patch-Makefile.linux