Bug 201050 - www/py-tornado: match_hostname dependency
Summary: www/py-tornado: match_hostname dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
: 200796 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-22 19:30 UTC by Ruslan Makhmatkhanov
Modified: 2015-06-23 19:50 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (khsing.cn)

Attachments
tornado.diff.txt (2.07 KB, text/plain)
2015-06-22 19:30 UTC, Ruslan Makhmatkhanov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-06-22 19:30:13 UTC 
Created attachment 157989 [details]
tornado.diff.txt

Hello Guixing,

since python 2.7.9 ssl.match_hostname() function is in standard library, so there is no need to depend on security/py-backports.ssl_match_hostname anymore as stated in tornado's setup.py:

"""
    if sys.version_info < (3, 2):
        install_requires.append('backports.ssl_match_hostname')
    if sys.version_info < (3, 4):
        # Certifi is also optional on 2.7.9+, although making our dependencies
        # conditional on micro version numbers seems like a bad idea
        # until we have more declarative metadata.
        install_requires.append('certifi')
"""

As you can see certifi package is also stated as not required on pythons>=2.7.9, but it is actually still used in simple_httpclient.py so I'd better retain it as is. But py-backports.ssl_match_hostname is already deprecated and expired in FreeBSD ports, so I'm asking you to approve patch attached, that removes it from py-tornado port along with setup.py version check tuning. I also did couple of minor fixes (whitespace and alphabetic sorting in USE_PYTHON).

Thanks in advance.
Comment 1 khsing.cn 2015-06-23 02:09:56 UTC 
Approved and Thanks
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-06-23 18:23:00 UTC 
A commit references this bug:

Author: rm
Date: Tue Jun 23 18:22:44 UTC 2015
New revision: 390441
URL: https://svnweb.freebsd.org/changeset/ports/390441

Log:
  www/py-tornado: remove py-backports.ssl_match_hostname dependency

  since python 2.7.9 ssl.match_hostname() function is in standard library, so
  there is no need to depend on security/py-backports.ssl_match_hostname anymore
  as stated in tornado's setup.py:

  """
    if sys.version_info < (3, 2):
        install_requires.append('backports.ssl_match_hostname')
    if sys.version_info < (3, 4):
        # Certifi is also optional on 2.7.9+, although making our dependencies
        # conditional on micro version numbers seems like a bad idea
        # until we have more declarative metadata.
        install_requires.append('certifi')
  """

  Remove this dependency and bump PORTREVISION.
  While here sort USE_PYTHON components, add missed space in Makefile header.

  PR:		201050
  Submitted by:	rm (myself)
  Approved by:	Guixing Bai <khsing.cn@gmail.com> (maintainer)

Changes:
  head/www/py-tornado/Makefile
  head/www/py-tornado/files/patch-setup.py
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-06-23 18:23:19 UTC 
Committed. Thanks.
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2015-06-23 19:50:22 UTC 
*** Bug 200796 has been marked as a duplicate of this bug. ***