Bug 201129 - www/nginx{-devel}: Fails to build with HEADERS_MORE option (distinfo)
Summary: www/nginx{-devel}: Fails to build with HEADERS_MORE option (distinfo)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch, regression
Depends on:
Blocks:
 
Reported: 2015-06-26 17:41 UTC by adam.twardowski
Modified: 2015-07-06 05:43 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback-


Attachments
Update size/hash in distinfo (1.09 KB, patch)
2015-06-26 17:47 UTC, adam.twardowski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description adam.twardowski 2015-06-26 17:41:44 UTC
Compile fails with HEADERS_MORE option enabled due to size/SHA256 has mismatch.

http://hastebin.com/xiwibixaki.coffee
Comment 1 adam.twardowski 2015-06-26 17:47:41 UTC
Created attachment 158078 [details]
Update size/hash in distinfo
Comment 2 adam.twardowski 2015-06-26 19:49:09 UTC
this bug appears to be caused by a change in the github tag for headers_more 0.26 as of 4 days ago.

https://github.com/openresty/headers-more-nginx-module/releases
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-07-03 16:45:57 UTC
A commit references this bug:

Author: koobs
Date: Fri Jul  3 16:45:00 UTC 2015
New revision: 391254
URL: https://svnweb.freebsd.org/changeset/ports/391254

Log:
  www/nginx{-deve}: Fix build with HEADERS_MORE option

  Upstream apparently re-tagged the v0.26 release, thereby changing the contents
  of the tarball oftained from github, causing distinfo checksums to become
  mismatched.

  This change updates distinfo entries in nginx and nginx-devel to compensate.

  PR:		201129
  Submitted by:	Adam Twardowski <adam dot twardowski gmail.com>
  Approved by:	portmgr (blanket)
  MFH:		2015Q3

Changes:
  head/www/nginx/Makefile
  head/www/nginx/distinfo
  head/www/nginx-devel/Makefile
  head/www/nginx-devel/distinfo
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-03 16:47:31 UTC
nginx and nginx-devel are super popular software packages so I opted to fix this on behalf of Sergey in case he was otherwise occupied.

This was build tested in poudriere, and changes were applied (beyond the original report in www/nginx) to nginx-devel as well.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-03 16:51:38 UTC
Committed, thank you Adam!
Comment 6 Sergey A. Osokin freebsd_committer freebsd_triage 2015-07-03 17:40:14 UTC
Kubilay,

I don't think this is about super popular nginx or nginx-devel ports, but about an issue with the headers_more module.

The size/SHA256 mismatch in third-party headers_more module has been acquired probably because of the module's author mistake: he's changed something in source code after release tagging.

In my point of view, I'd recommend to ask the module's author to create a new release with that change.

Any comments?
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-03 17:51:20 UTC
(In reply to Sergey A. Osokin from comment #6)

Absolutely agree with that recommendation. Upstreams re-rolling distfiles and moving tags (in this case) is bad practice at best, and disruptive in most if not all cases for downstream consumers that rely on them, as was the case here.

I mentioned that popularity of the nginx ports only as a warrant to commit the fix on your behalf. Apologies if that was out-of-line.

What is there left to do on this issue?
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-04 05:57:17 UTC
Upstream issue created post-commit to clarify changes in the 2nd version of v0.26, with explanation of the impact moving the tag caused:

https://github.com/openresty/headers-more-nginx-module/issues/35
Comment 9 Sergey A. Osokin freebsd_committer freebsd_triage 2015-07-04 22:09:56 UTC
Has been upgraded to 0.261.
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-05 00:39:21 UTC
Can you MFH? I havent merged my original commit yet. Your last one is probably the one we want instead
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-07-06 05:43:57 UTC
A commit references this bug:

Author: koobs
Date: Mon Jul  6 05:43:35 UTC 2015
New revision: 391391
URL: https://svnweb.freebsd.org/changeset/ports/391391

Log:
  MFH: r391254

  www/nginx{-deve}: Fix build with HEADERS_MORE option

  Upstream apparently re-tagged the v0.26 release, thereby changing the contents
  of the tarball oftained from github, causing distinfo checksums to become
  mismatched.

  This change updates distinfo entries in nginx and nginx-devel to compensate.

  PR:		201129

  Approved by:	portmgr (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/www/nginx/Makefile
  branches/2015Q3/www/nginx/distinfo
  branches/2015Q3/www/nginx-devel/Makefile
  branches/2015Q3/www/nginx-devel/distinfo