Created attachment 158134 [details] devel_synfig.shar - devel/etl: Update to version 0.4.18 - devel/synfig: Update to version 1.0 - graphics/synfigstudio: Update to version 1.0
Created attachment 159502 [details] devel_synfig.shar Chase r388831
FYI, this is a duplicate of my PR199802: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199802
Hi tkato, Unfortunately, we overlapped our efforts and both submitted patches for the same ports. The patches that I submitted in PR199802 have been committed. I believe that means this bug report is no longer required. If so, can you please close this bug report? Or, if there are any additional improvements which are not in the current ports tree, can you please highlight them? Thanks for your efforts!
Created attachment 160388 [details] devel_synfig.shar - devel/etl: Add NO_ARCH - devel/synfig: Add OPTIONS_DEFINE - graphics/synfigstudio: Add optional JACK support
Created attachment 160948 [details] Patch to improve related ports devel/etl, devel/synfig & graphics/synfigstudio
Comment on attachment 160388 [details] devel_synfig.shar Hi tkato, Thanks for your suggested improvements. I have included them all in my attached patch and added some others, so I will mark this attachment as maintainer-approval declined (as they are all included in the other attachment). Other improvements I made: - remove unnecessary setting of WRKSRC to ${WRKDIR}/${DISTNAME} - pet portlint (generate patches via makepatch, make NLS an option) - correct synfig license to GPLv2 or later Regards, Ben
Created attachment 160950 [details] devel/etl QA: Successful poudriere testport logs on FreeBSD 10.2 amd64
Created attachment 160951 [details] devel/synfig QA: Successful poudriere testport logs on FreeBSD 10.2 amd64 (gzipped)
Created attachment 160952 [details] graphics/synfigstudio QA: Successful poudriere testport logs on FreeBSD 10.2 amd64 (gzipped)
Wen, If you have time, could you please have a look at committing this patch (the second attachment which is my patch incorporating tkato's recommendations)? Thanks, Ben
Created attachment 161598 [details] Patch to update and improve related ports devel/etl, devel/synfig & graphics/synfigstudio This updated version of the patch also updates the ports as follows: devel/etl: Update from 0.04.18 to 0.04.19 devel/synfig: Update from 1.0 to 1.0.1 graphics/synfigstudio: Update from 1.0 to 1.0.1
Created attachment 161599 [details] QA: Successful poudriere testport logs of devel/etl-0.04.19 on FreeBSD 10.2 amd64
Created attachment 161600 [details] QA: Successful poudriere testport logs of devel/synfig-1.0.1 on FreeBSD 10.2 amd64 (gzipped)
Created attachment 161602 [details] QA: Successful poudriere testport logs of graphics/synfigstudio-1.0.1 on FreeBSD 10.2 amd64 (gzipped)
build-testing@work
(In reply to Kurt Jaeger from comment #15) > build-testing@work Thanks Kurt. Please be aware that the current graphics/synfigstudio port does not build on FreeBSD 9.3 amd64 (as you first reported in PR199802), and I am afraid this minor patch update does not fix that. It does build on all other releases, and I am still investigating the reason for this. I would like to commit this patch anyway, as it does not make things any worse than they already are. More details on my troubleshooting to date can be seen at the end of PR199802. Lastly, graphics/synfigstudio will fail to build if it the new option setting for NLS is different from the NLS option setting when devel/synfig was built (e.g. Synfigstudio will fail if the NLS option is disabled and the NLS option was enabled when synfig was built).
build-tests on cur-amd64, 10.2a+i OK, 9.3a failed. With maintainer approval: Mark 9.3 as broken for now, apply the update.
A commit references this bug: Author: pi Date: Sun Oct 4 10:43:33 UTC 2015 New revision: 398569 URL: https://svnweb.freebsd.org/changeset/ports/398569 Log: devel/etl: 0.4.18 -> 0.04.19 devel/synfig: 1.0 -> 1.0.1 graphics/synfigstudio: 1.0 -> 1.0.1 PR: 201175 Submitted by: Ben Woods <woodsb02@gmail.com> (maintainer) Changes: head/devel/etl/Makefile head/devel/etl/distinfo head/devel/etl/files/patch-ETL___stringf.h head/devel/etl/files/patch-ETL___surface.h head/devel/synfig/Makefile head/devel/synfig/distinfo head/devel/synfig/files/patch-src__synfig__main.cpp head/devel/synfig/files/patch-src__synfig__transform.cpp head/devel/synfig/pkg-plist head/graphics/synfigstudio/Makefile head/graphics/synfigstudio/distinfo head/graphics/synfigstudio/files/patch-src_synfigapp_cvs.cpp head/graphics/synfigstudio/pkg-plist
Committed, thanks. Please try to find a solution for 9.3.