Created attachment 158175 [details] Patch for obmenu Upon saving changes, Obmenu is supposed to make Openbox reload its config by sending SIGUSR2. However, it hardcodes this signal as signal #12, which works on Linux, but not on FreeBSD (Python reports signal.SIGUSR2 to be signal number 31). Instead, whenever Obmenu saves, Openbox dumps core and exits on signal #12. A patch to fix this is attached.
Created attachment 158417 [details] obmenu.diff Merging Bug 201211 with Bug 198031 I accept this patch, with modifications. Thank you. - Bump PORTREVISION - Add USES=shebangfix for SHEBANG_FILES=obmenu obxml.py pipes/obm-xdg - Add NO_ARCH - Patch obxml.py to show command in execute actions [1] - Patch obmenu: SIGUSR2 is hardcoded as signal #12, causing openbox to quit when it saves [2] [1] PR: 198031 Submitted by: JochenF [2] PR: 201211 Submitted by: James Lu # portlint -AC WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: new ports should not set PORTREVISION. 0 fatal errors and 2 warnings found.
Created attachment 158418 [details] obmenu-1.0_8-Bug201211-Bug198031-10amd64.log
Created attachment 158419 [details] obmenu-1.0_8-Bug201211-Bug198031-10i386.log
Created attachment 158420 [details] obmenu-1.0_8-Bug201211-Bug198031-9amd64.log
Created attachment 158421 [details] obmenu-1.0_8-Bug201211-Bug198031-9i386.log
Horia, can you please: * Set maintainer-approval for your own patch * Set one of the issues you referenced in comment 1 as depending on, or blocking the other * Set the 'obsolete flag' on any patches in either issue that is contained in this issues latest patch.
A commit references this bug: Author: riggs Date: Fri Jul 17 15:42:31 UTC 2015 New revision: 392381 URL: https://svnweb.freebsd.org/changeset/ports/392381 Log: Fix runtime error: hardcoded signal mapping causes openbox to quit while saving PR: 201211 Submitted by: glolol1@hotmail.com Reviewed by: horia@racoviceanu.com (maintainer) Approved by: horia@racoviceanu.com (maintainer) MFH: 2015Q3 Changes: head/x11-wm/obmenu/Makefile
A commit references this bug: Author: riggs Date: Fri Jul 17 15:53:55 UTC 2015 New revision: 392383 URL: https://svnweb.freebsd.org/changeset/ports/392383 Log: MFH: r392381 Fix runtime error: hardcoded signal mapping causes openbox to quit while saving PR: 201211 Submitted by: glolol1@hotmail.com Reviewed by: horia@racoviceanu.com (maintainer) Approved by: ports-secteam (feld) horia@racoviceanu.com (maintainer) Changes: _U branches/2015Q3/ branches/2015Q3/x11-wm/obmenu/Makefile