Bug 201255 - games/crafty: fix build on non-x86
Summary: games/crafty: fix build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 16:36 UTC by Dmitry Marakasov
Modified: 2015-07-01 19:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (johans)

Attachments
Patch (929 bytes, patch)
2015-07-01 16:36 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-01 16:36:39 UTC 
Created attachment 158227 [details]
Patch

Set CPUS=1 on non-x86. This leads to disabling custom thread synchronization primitives coded in x86 assembly and thus allows build (confirmed successful builds on mips and armv6, however haven't tested whether it actually works)
Comment 1 Johan van Selst freebsd_committer freebsd_triage 2015-07-01 19:55:51 UTC 
Well found. I remember looking into this a while ago, but missed that.
Thanks for the patch. Committed now.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-01 19:55:56 UTC 
A commit references this bug:

Author: johans
Date: Wed Jul  1 19:54:58 UTC 2015
New revision: 391118
URL: https://svnweb.freebsd.org/changeset/ports/391118

Log:
  - Fix build for several architectures.
    Set CPUS=1 on non-x86. This leads to disabling custom thread synchronization
    primitives coded in x86 assembly and thus allows build (confirmed successful
    builds on mips and armv6, however haven't tested whether it actually works).
  - Minor cleanups added to pet portlint

  PR:		201255
  Submitted by:	amdmi3

Changes:
  head/games/crafty/Makefile
  head/games/crafty/pkg-plist