Bug 201601 - [patch] net/isc-dhcp4[23]-server: Prefix delegation broken by new ISC DHCP Server 4.2.8/4.3.2 subnet check
Summary: [patch] net/isc-dhcp4[23]-server: Prefix delegation broken by new ISC DHCP Se...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ryan Steinmetz
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-15 19:44 UTC by Renato Botelho
Modified: 2015-07-16 11:56 UTC (History)
0 users

See Also:

Attachments
Disable prefix6 subnet check (3.70 KB, patch)
2015-07-15 19:44 UTC, Renato Botelho 		no flags Details | Diff
Improved fix (4.53 KB, patch)
2015-07-15 22:46 UTC, Renato Botelho 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2015-07-15 19:44:34 UTC 
Created attachment 158811 [details]
Disable prefix6 subnet check

Since 4.2.8/4.3.2, there is a check that forces prefix6 to be within declared subnet. A bug was reported on pfSense:

https://redmine.pfsense.org/issues/4829

And also a discussion can be found here:

https://lists.isc.org/pipermail/dhcp-users/2015-July/019098.html

The patch removes this check from current versions.

Sponsored by: Netgate
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2015-07-15 19:49:13 UTC 
Has this been reported to ISC?
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2015-07-15 19:55:56 UTC 
(In reply to Ryan Steinmetz from comment #1)

I'm not sure. Is there any ISC public bug tracker?

But based on this answer from Shawn Routhier they are aware of the problem:

"We are re-consdiering this change and would be interested in hearing
peoples comments."

https://lists.isc.org/pipermail/dhcp-users/2015-July/019099.html
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2015-07-15 22:00:49 UTC 
Approved, please commit.
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2015-07-15 22:46:01 UTC 
Created attachment 158816 [details]
Improved fix

There is one more change to be reverted, it is checking the subnet mask. It was introduced in the same version:

http://fossies.org/diffs/dhcp/4.2.7_vs_4.2.8rc1/server/confpars.c-diff.html

I'll wait a new approval for this version.
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2015-07-16 00:29:56 UTC 
Approved.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-07-16 11:52:21 UTC 
A commit references this bug:

Author: garga
Date: Thu Jul 16 11:51:59 UTC 2015
New revision: 392293
URL: https://svnweb.freebsd.org/changeset/ports/392293

Log:
  Since 4.2.8/4.3.2 isc-dhcp-server started to check if prefix6 range is
  within declared subnet and if prefix6 network mask is bigger or equal
  subnet mask. Remove these checks and make prefix delegation work as
  expected.

  For reference - https://redmine.pfsense.org/issues/4829

  PR:		201601
  Approved by:	zi (maintainer)
  Sponsored by:	Netgate

Changes:
  head/net/isc-dhcp42-server/Makefile
  head/net/isc-dhcp42-server/files/patch-server_confpars.c
  head/net/isc-dhcp43-server/Makefile
  head/net/isc-dhcp43-server/files/patch-server_confpars.c