Bug 201666 - [patch] mail/postfixadmin - Missing dependencies for vacation script.
Summary: [patch] mail/postfixadmin - Missing dependencies for vacation script.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Carlo Strub
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-17 23:18 UTC by ek
Modified: 2015-09-11 23:20 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ports.maintainer)


Attachments
Postfixadmin vacation script dependency patch. (519 bytes, patch)
2015-07-17 23:18 UTC, ek
no flags Details | Diff
Revised patch adding perl dependencies for vacation.pl (735 bytes, text/plain)
2015-07-22 07:47 UTC, Mel Pilgrim
no flags Details
Second revision, get the dependencies right (968 bytes, text/plain)
2015-07-22 08:24 UTC, Mel Pilgrim
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ek 2015-07-17 23:18:32 UTC
Created attachment 158925 [details]
Postfixadmin vacation script dependency patch.

When running the vacation.pl script, the below Perl dependencies are missing:

${PORTSDIR}/mail/p5-MIME-EncWords
${PORTSDIR}/mail/p5-Email-Valid
${PORTSDIR}/mail/p5-Mail-Sender
${PORTSDIR}/devel/p5-Log-Log4perl
${PORTSDIR}/devel/p5-Log-Dispatch 

I've attached a Makefile patch but there may be a better way to handle it.
Comment 1 Mel Pilgrim 2015-07-22 07:47:14 UTC
Created attachment 159059 [details]
Revised patch adding perl dependencies for vacation.pl
Comment 2 Mel Pilgrim 2015-07-22 07:50:32 UTC
Thank you for catching this, and thank you for taking the time to hunt down the modules needed.  The patch you provided was a good start--it only needed a few more bits to properly bring in the Ports System's methods for handling perl dependencies.  Please try out attachment 159059 [details] and let me know if it works correctly.
Comment 3 Mel Pilgrim 2015-07-22 08:24:55 UTC
Created attachment 159060 [details]
Second revision, get the dependencies right
Comment 4 Mel Pilgrim 2015-07-22 08:27:47 UTC
Strike that that last, try attachment 159060 [details] instead.  The odd way of making a port say "I need this package installed, don't go checking for a file, just install it if it isn't installed" always bites me.
Comment 5 ek 2015-07-26 17:45:50 UTC
Hi Mellisa,

Thanks for looking into this and supplying the revised patch. It looks good and works just fine for me.
Comment 6 Mel Pilgrim 2015-07-27 17:35:26 UTC
Thank you for reviewing.  Someone with a commit bit please commit attachment 159060 [details].  Thank you.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-09-11 23:18:50 UTC
A commit references this bug:

Author: cs
Date: Fri Sep 11 23:18:00 UTC 2015
New revision: 396722
URL: https://svnweb.freebsd.org/changeset/ports/396722

Log:
  Add vacation script dependencies

  PR:		201666
  Submitted by:	ek@purplehat.org
  Approved by:	Melissa Pilgrim (maintainer)

Changes:
  head/mail/postfixadmin/Makefile
Comment 8 Carlo Strub freebsd_committer freebsd_triage 2015-09-11 23:20:07 UTC
Committed with slight rearrangements to please portlint. Thank you very much.