Bug 201733 - databases/levigo: CONFIGURE_ENV is recursive
Summary: databases/levigo: CONFIGURE_ENV is recursive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jason Unovitch
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2015-07-21 08:03 UTC by Ralf van der Enden
Modified: 2015-11-06 20:24 UTC (History)
2 users (show)

See Also:
cheffo: maintainer-feedback+

Attachments
levigo-20150216_1.patch (442 bytes, patch)
2015-07-24 01:46 UTC, Jason Unovitch 		no flags Details | Diff
Poudriere testport log from 10.2-BETA2 jail (10.46 KB, text/x-log)
2015-07-24 01:51 UTC, Jason Unovitch 		no flags Details
levigo-20150216.patch (306 bytes, patch)
2015-08-04 01:36 UTC, Jason Unovitch 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2015-07-21 08:03:55 UTC 
The following lines from the Makefile are the cause of the error when trying to run any make command for this port:

CONFIGURE_ENV+= CC=${CC} \
                CXX=${CXX} \
GO_ENV+=        ${CONFIGURE_ENV}

Most likely the second backslash needs to be removed.

I ran into this while running 'portsdb -U', which in turn runs a 'make describe' in all port directories.
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-07-24 01:46:31 UTC 
Created attachment 159126 [details]
levigo-20150216_1.patch

Thanks!

Patch attached to fix and bump PORTREVISION so the package actually gets compiled with the right compiler and options.

Before:

--CONFIGURE_ENV--
Variable CONFIGURE_ENV is recursive.

After:

--CONFIGURE_ENV--
CC=clang  CXX=c++ XDG_DATA_HOME=/wrkdirs/usr/ports/databases/levigo/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/databases/levigo/work  HOME=/wrkdirs/usr/ports/databases/levigo/work TMPDIR="/tmp" SHELL=/bin/sh CONFIG_SHELL=/bin/sh
--End CONFIGURE_ENV--
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2015-07-24 01:51:20 UTC 
Created attachment 159127 [details]
Poudriere testport log from 10.2-BETA2 jail

Full Poudriere log attached to supplement the mention of the CONFIGURE_ENV fix mentioned above.  Also tested on the list below:

9.3-RELEASE-p17      amd64
9.3-RELEASE-p17      i386
10.1-RELEASE-p14     amd64
10.1-RELEASE-p14     i386
10.2-BETA2           amd64
10.2-BETA2           i386
11.0-CURRENT r284725 amd64
11.0-CURRENT r284725 i386

8.4 is a known failure per the Makefile and the only portlint QA item is a false positive regarding the warning used to mark FreeBSD 8.x as BROKEN.
WARN: Makefile: possible use of absolute pathname "/readelf.core,".

Looks good to me.
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-08-04 01:36:04 UTC 
Created attachment 159514 [details]
levigo-20150216.patch

Disregard comment about PORTREVISION.  I validated SHAs do match.  Everything above is still valid, pending mentor review.

Log:
Trim spurious slash that caused recursive CONFIGURE_ENV warning

PR:		201733
Submitted by:	tremere@cainites.net
Approved by:	cheffo@freebsd-bg.org (maintainer), (feld|delphij|pgollucci) (mentor)
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-08-04 02:27:40 UTC 
A commit references this bug:

Author: junovitch
Date: Tue Aug  4 02:27:34 UTC 2015
New revision: 393507
URL: https://svnweb.freebsd.org/changeset/ports/393507

Log:
  Trim spurious slash that caused recursive CONFIGURE_ENV warning

  PR:		201733
  Submitted by:	tremere@cainites.net
  Approved by:	cheffo@freebsd-bg.org (maintainer), pgollucci (mentor)

Changes:
  head/databases/levigo/Makefile
Comment 5 Jason Unovitch freebsd_committer freebsd_triage 2015-08-04 02:28:47 UTC 
Committed. Thanks! I'll close this when I get my Bugzilla permissions straightened out.