Created attachment 159198 [details] diff for version bump. Version bump 3.3.3 -> 3.3.7
====>> Building 1 packages using 1 builders ====>> Starting/Cloning builders ====>> Hit CTRL+t at any time to see build progress and stats ====>> [01] Starting build of databases/pgpool-II-33 ====>> [01] Status for build databases/pgpool-II-33: check-sanity ====>> [01] Status for build databases/pgpool-II-33: pkg-depends ====>> [01] Status for build databases/pgpool-II-33: fetch-depends ====>> [01] Status for build databases/pgpool-II-33: fetch ====>> [01] Status for build databases/pgpool-II-33: checksum ====>> [01] Status for build databases/pgpool-II-33: distfiles ====>> [01] Status for build databases/pgpool-II-33: extract-depends ====>> [01] Status for build databases/pgpool-II-33: extract ====>> [01] Status for build databases/pgpool-II-33: patch-depends ====>> [01] Status for build databases/pgpool-II-33: patch ====>> [01] Status for build databases/pgpool-II-33: build-depends ====>> [01] Status for build databases/pgpool-II-33: lib-depends ====>> [01] Status for build databases/pgpool-II-33: configure ====>> [01] Status for build databases/pgpool-II-33: build ====>> [01] Status for build databases/pgpool-II-33: run-depends ====>> [01] Status for build databases/pgpool-II-33: stage ====>> [01] Status for build databases/pgpool-II-33: package ====>> [01] Status for build databases/pgpool-II-33: install-mtree ====>> [01] Status for build databases/pgpool-II-33: install ====>> [01] Finished build of databases/pgpool-II-33: Success ====>> Completed: 1 of 1 ====>> Stopping 1 builders
Created attachment 159748 [details] Updated patch Hello, I had a minor issue with the patch in that "PORTVERSION= 3.3.7" was already set in the patch. I am thinking you have have a later version in your own internal repo. This patch is against the current SVN master and also resolves a minor `portlint -ac` nit for consistency with USES options. WARN: Makefile: [15]: the options to USES are not sorted. Please consider sorting them.
Created attachment 159749 [details] Poudriere testport log from 10.1-RELEASE jail I tested the patch with pgsql=9.2, pgsql=9.3 (attached), and pgsql=9.4 in my make.conf on 9.3-RELEASE, 10.1-RELEASE, 10.2-RC2, and CURRENT and didn't see any issues.
Odd you should say that: [michelle@colossus /Storage/source/ports/head/databases]$ portlint -ac pgpool-II-33/ WARN: Makefile: [6]: whitespace before end of line. WARN: /Storage/source/ports/head/databases/pgpool-II-33/files/patch-pool_hba.c: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' to ensure proper patch format. WARN: /Storage/source/ports/head/databases/pgpool-II-33/files/patch-recovery.c: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' to ensure proper patch format. WARN: /Storage/source/ports/head/databases/pgpool-II-33/files/patch-watchdog__watchdog.h: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' to ensure proper patch format. 0 fatal errors and 4 warnings found. Nothing mentioned about USES...
(In reply to Michelle Sullivan from comment #4) The most recent portlint-2.16.6 does this. It also clarifies only using make makepatch when changing patches to minimize repo churn when the patches haven't changed. Are you ok with the patch?
Sorry missed you had uploaded a patch (my excuse: I've been having problems with my desktop panicing) Added maintainer approved flag (as I do approve)
A commit references this bug: Author: junovitch Date: Wed Aug 12 03:11:39 UTC 2015 New revision: 394003 URL: https://svnweb.freebsd.org/changeset/ports/394003 Log: databases/pgpool-II-33: update 3.3.3_1 -> 3.3.7 PR: 201862 Submitted by: Michelle Sullivan <michelle@sorbs.net> (maintainer) Approved by: pgollucci (mentor) Changes: head/databases/pgpool-II-33/Makefile head/databases/pgpool-II-33/distinfo
Committed and closing. Thanks for your patch submission.