Bug 201929 - www/ckeditor: file owner setting problem
Summary: www/ckeditor: file owner setting problem
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-27 18:35 UTC by Dmitry Marakasov
Modified: 2015-09-03 10:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joehorn)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-27 18:35:56 UTC
Since switch to pkg, setting file owner during ckeditor installation was broken: though it tries to set owner via -R${WWWOWN}:${WWWGRP}, it does nothing as pkg resets it to root. Actually, setting owner of all files to www is a security hole. Either you should not try to set owner at all, or owner should be set via plist @owner/@group directives, and only for specific directories, which need to be writable by www.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-09-03 10:12:43 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Sep  3 10:12:18 UTC 2015
New revision: 395943
URL: https://svnweb.freebsd.org/changeset/ports/395943

Log:
  - Remove CHOWNing of installed files; this was broken with pkg, and doesn't seem needed and in fact is a security problem
  - Drop @dirrm from plist
  - Add NO_ARCH

  PR:		201929
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (joehorn@gmail.com, 5 weeks)

Changes:
  head/www/ckeditor/Makefile
  head/www/ckeditor/pkg-plist