Bug 202498 - Fix games/doomlegacy build with clang 3.7.0
Summary: Fix games/doomlegacy build with clang 3.7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks: 201377
  Show dependency treegraph
 
Reported: 2015-08-19 21:47 UTC by Dimitry Andric
Modified: 2015-08-20 06:49 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
Fix use of inline function in games/doomlegacy (996 bytes, patch)
2015-08-19 21:47 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-08-19 21:47:03 UTC
Created attachment 160116 [details]
Fix use of inline function in games/doomlegacy

During the exp-run in bug 201377, it was found that games/doomlegacy gives errors with a recent clang 3.7.0 snapshot:

http://package18.nyi.freebsd.org/data/headi386PR201377-default/2015-07-31_12h04m22s/logs/errors/doomlegacy-1.45.2,1.log

This is because the program uses the wrong form of inline function, causing linking to fail.  This can be fixed easily by using "static inline" instead.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-08-20 06:30:30 UTC
Thanks, will fix; just had reported upstream: https://sourceforge.net/p/doomlegacy/bugs/623/
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-08-20 06:47:04 UTC
A commit references this bug:

Author: danfe
Date: Thu Aug 20 06:46:34 UTC 2015
New revision: 394834
URL: https://svnweb.freebsd.org/changeset/ports/394834

Log:
  During the exp-run in PR 201377, it was found that `games/doomlegacy' gives
  errors with a recent Clang 3.7.0 snapshot (final linking fails).

  This is because the program uses the wrong form of inline function, causing
  linking to fail.  This can be fixed easily by using "static inline" instead.

  PR:		202498
  Submitted by:	dim

Changes:
  head/games/doomlegacy/Makefile
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-08-20 06:49:33 UTC
Committed as ports r394834.  Because of the triviality of the change I went with in-place patching in the Makefile rather than adding a dedicated patch file.