Bug 202535 - Fix net-mgmt/tcptrack build with clang 3.7.0
Summary: Fix net-mgmt/tcptrack build with clang 3.7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 201377
  Show dependency tree / graph
 
Reported: 2015-08-20 21:39 UTC by Dimitry Andric
Modified: 2015-08-26 00:31 UTC (History)
2 users (show)

See Also:

Attachments
Fix infinite recursion in net-mgmt/tcptrack (1.12 KB, patch)
2015-08-20 21:39 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-08-20 21:39:58 UTC 
Created attachment 160159 [details]
Fix infinite recursion in net-mgmt/tcptrack

During the exp-run in bug 201377, it was found that net-mgmt/tcptrack gives errors with a recent clang 3.7.0 snapshot:

http://package18.nyi.freebsd.org/data/headi386PR201377-default/2015-07-31_12h04m22s/logs/errors/tcptrack-1.4.2_2.log

This is because the program has a function with infinite recursion.  The attached patch fixes this.
Comment 1 Chris Hutchinson 2015-08-25 17:54:48 UTC 
I use this utility fairly frequently. So I was
eager to incorporate your patch, when I saw you
had discovered the recursive loop.
I also decided to adopt it :-)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202658

--Chris
Comment 2 Xin LI freebsd_committer freebsd_triage 2015-08-26 00:30:57 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-08-26 00:31:14 UTC 
A commit references this bug:

Author: delphij
Date: Wed Aug 26 00:30:37 UTC 2015
New revision: 395328
URL: https://svnweb.freebsd.org/changeset/ports/395328

Log:
   - Add more MASTERSITE;
   - Fix a bug revealed by clang 3.7 [1]
   - Give maintainership to submitter [2];

  PR:		ports/202535 [1], ports/202658 [2]
  Submitted by:	dim [1], Chris Hutchinson [2]

Changes:
  head/net-mgmt/tcptrack/Makefile
  head/net-mgmt/tcptrack/files/patch-IPAddress.h
  head/net-mgmt/tcptrack/pkg-descr