Bug 202547 - [patch] net-im/licq-qt-gui: qt4-linguist -> qt4-linguisttools, use OPTIONS helpers
Summary: [patch] net-im/licq-qt-gui: qt4-linguist -> qt4-linguisttools, use OPTIONS he...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-21 14:48 UTC by Andriy Voskoboinyk
Modified: 2015-09-05 15:16 UTC (History)
1 user (show)

See Also:
avos: maintainer-feedback?

Attachments
Patch.diff (6.24 KB, patch)
2015-08-21 14:48 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (296 bytes, text/plain)
2015-08-21 14:49 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-hunspell.log (417.09 KB, text/plain)
2015-08-21 14:52 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-kde.log (580.86 KB, text/plain)
2015-08-21 14:52 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-default.log (434.11 KB, text/plain)
2015-08-21 14:58 UTC, Andriy Voskoboinyk 		no flags Details
Makefile.diff (1.63 KB, patch)
2015-08-27 15:07 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (1.09 KB, text/plain)
2015-08-27 15:08 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-default.log (432.61 KB, text/plain)
2015-08-27 15:12 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-kde.log (581.19 KB, text/plain)
2015-08-27 15:13 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-hunspell.log (417.37 KB, text/plain)
2015-08-27 15:26 UTC, Andriy Voskoboinyk 		no flags Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-21 14:48:33 UTC 
Created attachment 160173 [details]
Patch.diff

- Add HUNSPELL option (disabled by default, not used when KDE is selected).
- Use OPTIONS helpers where possible.
- Use qt4-linguisttools instead of qt4-linguist for *.ts files.
- Depend on qt4-xml and qt4-gui even when KDE is selected (they are used anyway).
- Sort USE_XORG.
- Regenerate patches.
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-21 14:49:16 UTC 
Created attachment 160174 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-21 14:52:40 UTC 
Created attachment 160175 [details]
poudriere-9.3-i386-hunspell.log
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-21 14:52:58 UTC 
Created attachment 160176 [details]
poudriere-9.3-i386-kde.log
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-21 14:58:57 UTC 
Created attachment 160177 [details]
poudriere-10.2-amd64-default.log
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2015-08-24 18:12:47 UTC 
Do NOT rename the patch-files!

The order of XORG should match the order of the libs used in linking.
Sorting the list alphabetic is confusing,
it changes the order of dependencies and make verifying it more complex.
Comment 6 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-27 15:07:38 UTC 
Created attachment 160408 [details]
Makefile.diff

Don't touch patches & USE_XORG (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202547#c5)
Comment 7 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-27 15:08:28 UTC 
Created attachment 160409 [details]
portlint.log
Comment 8 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-27 15:12:31 UTC 
Created attachment 160410 [details]
poudriere-10.2-amd64-default.log
Comment 9 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-27 15:13:31 UTC 
Created attachment 160411 [details]
poudriere-9.3-i386-kde.log
Comment 10 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-08-27 15:26:45 UTC 
Created attachment 160412 [details]
poudriere-9.3-i386-hunspell.log
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-09-05 15:15:56 UTC 
A commit references this bug:

Author: dinoex
Date: Sat Sep  5 15:15:43 UTC 2015
New revision: 396181
URL: https://svnweb.freebsd.org/changeset/ports/396181

Log:
  - Add HUNSPELL option (enabled by default)
  - Use qt4-linguisttools instead of qt4-linguist for *.ts files.
  - Depend on qt4-xml and qt4-gui even when KDE is selected (they are used anyway).
  - Use OPTIONS helpers where possible.
  PR:		202547
  Submitted by:	Andriy Voskoboinyk

Changes:
  head/net-im/licq-qt-gui/Makefile