Bug 202560 - [PATCH] www/chromium: fix install with DRIVER option active
Summary: [PATCH] www/chromium: fix install with DRIVER option active
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-22 01:51 UTC by Carlos J Puga Medina
Modified: 2015-08-22 09:46 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
Patch (615 bytes, patch)
2015-08-22 04:39 UTC, Carlos J Puga Medina
no flags Details | Diff
Patch (962 bytes, patch)
2015-08-22 08:31 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-08-22 01:51:07 UTC
It seems that the chromedriver binary isn't build.

===>   Generating temporary packing list
install  -m 444 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/chrome.1 /usr/ports/www/chromium/work/stage/usr/local/man/man1
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_22.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/22x22/apps/chrome.png
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_24.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/24x24/apps/chrome.png
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_48.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/48x48/apps/chrome.png
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_64.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/64x64/apps/chrome.png
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_128.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/128x128/apps/chrome.png
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/app/theme/chromium/product_logo_256.png  /usr/ports/www/chromium/work/stage/usr/local/share/icons/hicolor/256x256/apps/chrome.png
install  -m 555 /usr/ports/www/chromium/work/chromium-44.0.2403.155/chrome/tools/build/linux/chrome-wrapper  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/chrome_100_percent.pak  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/content_resources.pak  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/keyboard_resources.pak  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -m 0644 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/resources.pak  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -s -m 555 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/chrome  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
cd /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release &&  /bin/sh -c '(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >/dev/null  2>&1) &&  /usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; &&  /usr/bin/find -d $0 $2 -type f -exec chmod 444 $1/{} \;' -- "locales resources" /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -m 0644 /usr/ports/www/chromium/work/chromium-browser.desktop  /usr/ports/www/chromium/work/stage/usr/local/share/applications
install  -m 555 /usr/ports/www/chromium/work/chrome /usr/ports/www/chromium/work/stage/usr/local/bin
install  -s -m 555 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/mksnapshot  /usr/ports/www/chromium/work/stage/usr/local/share/chromium
install  -s -m 555 /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/chromedriver  /usr/ports/www/chromium/work/stage/usr/local/bin
install: /usr/ports/www/chromium/work/chromium-44.0.2403.155/out/Release/chromedriver: No such file or directory
*** Error code 71

Stop.
make[1]: stopped in /usr/ports/www/chromium
*** Error code 1

Stop.
make: stopped in /usr/ports/www/chromium
Comment 1 Carlos J Puga Medina 2015-08-22 04:29:04 UTC
# cd /usr/port/www/chromium
# make -V MAKE_ARGS
-C out/Release
Comment 2 Carlos J Puga Medina 2015-08-22 04:39:21 UTC
Created attachment 160203 [details]
Patch
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-08-22 07:18:17 UTC
Comment on attachment 160203 [details]
Patch

Why not move DRIVER_MAKE_ARGS and MAKE_ARGS before bsd.port.options.mk instead?
Comment 4 Carlos J Puga Medina 2015-08-22 08:31:42 UTC
Created attachment 160207 [details]
Patch

You're right, Jan.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2015-08-22 09:29:22 UTC
Hmm, it does work for me, but I'll change the Makefile.

[9i386-default] Installing chromium-44.0.2403.155...
===> SECURITY REPORT: 
      This port has installed the following files which may act as network
      servers and may therefore pose a remote security risk to the system.
/usr/local/share/chromium/chrome
/usr/local/bin/chromedriver
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-08-22 09:29:42 UTC
A commit references this bug:

Author: rene
Date: Sat Aug 22 09:29:15 UTC 2015
New revision: 395024
URL: https://svnweb.freebsd.org/changeset/ports/395024

Log:
  Move definitions of MAKE_ARGS up to ensure that chromedriver is built when
  requested [1]

  While here sort USES

  PR:		202560 [1]
  Submitted by:	Carlos J Puga Medina [1]
  MFH:		2015Q3

Changes:
  head/www/chromium/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-08-22 09:46:44 UTC
A commit references this bug:

Author: rene
Date: Sat Aug 22 09:45:45 UTC 2015
New revision: 395025
URL: https://svnweb.freebsd.org/changeset/ports/395025

Log:
  MFH: r395024

  Move definitions of MAKE_ARGS up to ensure that chromedriver is built when
  requested [1]

  While here sort USES

  PR:		202560 [1]
  Submitted by:	Carlos J Puga Medina [1]
  Approved by:	ports-secteam (delphij)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/www/chromium/Makefile