Bug 202573 - audio/deadbeef: build fails on -CURRENT
Summary: audio/deadbeef: build fails on -CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Veniamin Gvozdikov
URL:
Keywords:
: 199319 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-22 16:33 UTC by Roman Bogorodskiy
Modified: 2021-10-02 01:55 UTC (History)
2 users (show)

See Also:
novel: maintainer-feedback? (vg)

Attachments
disable static libs (4.21 KB, patch)
2015-09-01 16:29 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bogorodskiy freebsd_committer freebsd_triage 2015-08-22 16:33:52 UTC 
On -CURRENT I have build fails like this:

gmake[5]: Entering directory '/usr/home/novel/ports_stuff/deadbeef/work/deadbeef-0.6.2/plugins/gtkui'
 /bin/mkdir -p '/usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef'
 /bin/sh ../../libtool   --mode=install /usr/bin/install -c -s  ddb_gui_GTK2.la '/usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef'
libtool: install: /usr/bin/install -c .libs/ddb_gui_GTK2.so /usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.so
libtool: install: strip --strip-unneeded /usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.so
libtool: install: /usr/bin/install -c .libs/ddb_gui_GTK2.lai /usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.la
libtool: install: /usr/bin/install -c .libs/ddb_gui_GTK2.a /usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.a
libtool: install: strip --strip-debug /usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.a
strip: file format not recognized
Makefile:889: recipe for target 'install-pkglibLTLIBRARIES' failed
gmake[5]: *** [install-pkglibLTLIBRARIES] Error 1


Running file(1) on this file says:

/usr/home/novel/ports_stuff/deadbeef/work/stage/usr/local/lib/deadbeef/ddb_gui_GTK2.a: current ar archive

I'm running today's -CURRENT/amd64. I've started to see this problem for a few weeks on -CURRENT though.
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-09-01 16:29:37 UTC 
Created attachment 160595 [details]
disable static libs

Adding a part that add '--disable-static' to configure args and drops static libs from the plist. Upstream suggested it's a safe thing to do:

https://github.com/Alexey-Yakovenko/deadbeef/issues/1255#issuecomment-134326260

and it fixes build on -CURRENT for me.
Comment 2 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-09-01 16:33:57 UTC 
Ok. Commit it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-09-01 17:13:28 UTC 
A commit references this bug:

Author: novel
Date: Tue Sep  1 17:12:32 UTC 2015
New revision: 395786
URL: https://svnweb.freebsd.org/changeset/ports/395786

Log:
  Deadbeef creates ar-inside-ar during the build and that causes
  build failure on -CURRENT because strip cannot handle this. As it
  was confirmed by upstream that it's safe to disable static libs [1],
  do and and fix build on -CURRENT.

  Drop static libs from plist and bump PORTREVISION.

  1: https://github.com/Alexey-Yakovenko/deadbeef/issues/1255

  PR:		202573
  Approved by:	vg (maintainer)

Changes:
  head/audio/deadbeef/Makefile
  head/audio/deadbeef/pkg-plist
Comment 4 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-09-01 17:28:06 UTC 
Done, thanks!
Comment 5 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-09-01 17:29:17 UTC 
*** Bug 199319 has been marked as a duplicate of this bug. ***