Bug 202576 - audio/deadbeef: respect OGG option
Summary: audio/deadbeef: respect OGG option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Veniamin Gvozdikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-22 17:02 UTC by Roman Bogorodskiy
Modified: 2015-09-01 16:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vg)

Attachments
respect ogg option (393 bytes, patch)
2015-08-22 17:02 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bogorodskiy freebsd_committer freebsd_triage 2015-08-22 17:02:15 UTC 
Created attachment 160218 [details]
respect ogg option

Currently the OGG option is not respected:

(19:57) novel@kloomba:/usr/ports/audio/deadbeef %> sudo make showconfig|grep OGG
     OGG=off: Ogg media format support
(19:57) novel@kloomba:/usr/ports/audio/deadbeef %> sudo make clean configure 2>/dev/null|grep vorbis
    vorbis: yes - ogg vorbis player
config.status: creating plugins/vorbis/Makefile
(19:58) novel@kloomba:/usr/ports/audio/deadbeef %> 

It was fixed upstream:

https://github.com/Alexey-Yakovenko/deadbeef/commit/f58d6e38ac9725fd1fe7760232a36bcefa940ee4

I have reproduced this fix using sed(1)

(19:59) novel@kloomba:~/ports_stuff/deadbeef %> make showconfig|grep OGG
     OGG=off: Ogg media format support
(19:59) novel@kloomba:~/ports_stuff/deadbeef %> make clean configure 2>/dev/null|grep vorbis
    vorbis: no - ogg vorbis player
config.status: creating plugins/vorbis/Makefile
(19:59) novel@kloomba:~/ports_stuff/deadbeef %>
Comment 1 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-08-27 19:24:29 UTC 
Approved, commit it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-09-01 16:22:18 UTC 
A commit references this bug:

Author: novel
Date: Tue Sep  1 16:22:12 UTC 2015
New revision: 395778
URL: https://svnweb.freebsd.org/changeset/ports/395778

Log:
  Respect disabling OGG option. Fix is based on an upstream commit [1].

  Do not bump PORTREVISION as OGG option is enabled by default.

  1: https://github.com/Alexey-Yakovenko/deadbeef/commit/f58d6e38ac9725fd1fe7760232a36bcefa940ee4

  PR:		202576
  Approved by:	vg (maintainer)

Changes:
  head/audio/deadbeef/Makefile
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-09-01 16:23:33 UTC 
Committed, thanks!