Created attachment 161017 [details]
Shar of port version 9.8.0

Created attachment 161018 [details]
10.2-RELEASE amd64 poudriere log

Created attachment 161019 [details]
10.2-RELEASE i386 poudriere log

Created attachment 161020 [details]
9.3-RELEASE amd64 poudriere log

Created attachment 161024 [details]
9.3-RELEASE i386 poudriere log

Created attachment 162586 [details]
guacamole-client.shar

Created attachment 162587 [details]
guacamole-client.diff

Comment 8 Kubilay Kocak 2015-10-30 09:32:15 UTC

@Ultima, patch or shar, pick one, obsolete the other :)

"Technically" shar is what the docs say is correct for new ports.

If you want to go one step ahead, include (in a diff), the addition of the port to category/Makefile as well :)

For more, see: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-adding

Created attachment 162595 [details]
guacamole-client.diff

Yeah, I wasn't really sure thanks for clearing that up koobs =]

Created attachment 164788 [details]
guacamole-client.diff

* Added LICENSE

portlint -AC: WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 1 warning found.

This is the source name, leaving it as is.

Created attachment 164789 [details]
10.2-RELEASE amd64 poudriere log

Created attachment 164790 [details]
10.2-RELEASE i386 poudriere log

Created attachment 164791 [details]
9.3-RELEASE amd64 poudriere log

Created attachment 164792 [details]
9.3-RELEASE i386 poudriere log

Created attachment 165155 [details]
guacamole-client.diff

* Updated to 0.9.9

Portlint -AC: WARN:
Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 1 warning found.  Ignoring, this is the ports name.

Poudriere -t -C: default(all) options 102amd64-ok 102i386-ok 93amd64-ok 93i386-ok

Comment 16 Kurt Jaeger 2016-02-06 16:43:02 UTC

There is an issue with maven-based ports.

See

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188110#c37

for details. Basically, maven normally fetches dependencies during the build phase, which is not allowed if the port builds in poudriere. Therefore,
the dependencies need to be provided in some custom zip file before the build starts.

Can you for example have a look at eclipse and try to find a solution for that ?

Yes, we know, it's messy 8-(

Comment 17 Kurt Jaeger 2016-02-06 17:02:55 UTC

Btw, I changed mvn31 to mvn33.

Comment 18 Kubilay Kocak 2016-02-06 17:38:01 UTC

Comment on attachment 165155 [details]
guacamole-client.diff

New ports dont have/need maintainer-approval

(In reply to Kurt Jaeger from comment #16)
 I added a gz that has all the mvn files required to build. This is downloaded during the fetch stage. (repository-${PORTVERSION}${EXTRACT_SUFX}:repo) so there is no downloading required during build. When mvn is built the "-Duser.home" arg sets the home for these files to the work directory this can be higher maintenance tho.


 I looked at the eclipse port and this was done in a similar manor. Do I need to change something else? possibly the name of the zip to be more understandable?

(In reply to Kurt Jaeger from comment #17)
I'll test 33 to see what changed.

Comment 21 Kurt Jaeger 2016-02-06 19:08:36 UTC

My buildlogs see

http://people.freebsd.org/~pi/logs/www__guacamole-client-10a-1454776996.txt

for 10i, 93a, cur, see the corresponding files.

(In reply to Kurt Jaeger from comment #21)
The repo files must have changed with the newer version of mvn. Will regenerate repo file and repost patch

Created attachment 166668 [details]
guacamole-client.diff

* Changed to maven33
* Regenerated repo file for maven33

Portlint -AC:
www/guacamole-client
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.

Poudriere bulk -t -C -j 102amd64: default options successfully builds

Comment 24 Kurt Jaeger 2016-02-06 20:57:45 UTC

Testbuilds all fine.

Comment 25 commit-hook 2016-02-06 21:00:10 UTC

A commit references this bug:

Author: pi
Date: Sat Feb  6 20:59:30 UTC 2016
New revision: 408311
URL: https://svnweb.freebsd.org/changeset/ports/408311

Log:
  New port: www/guacamole-client

  guacamole-client is the superproject containing all Maven-based
  projects that make Guacamole, an HTML5 web application that provides
  access to your desktop using remote desktop protocols.

  guacamole-client is used to build the subprojects that make up
  Guacamole, and to provide a common central repository. Each project
  contained here is completely independent of guacamole-client and
  can be built separately, though the others may have to be built
  first. If all projects are built using guacamole-client, Maven will
  take care of the proper build order.

  WWW: https://github.com/glyptodon/guacamole-client

  PR:		202755
  Submitted by:	ultima1252@gmail.com

Changes:
  head/www/Makefile
  head/www/guacamole-client/
  head/www/guacamole-client/Makefile
  head/www/guacamole-client/distinfo
  head/www/guacamole-client/files/
  head/www/guacamole-client/files/guacamole.properties.sample
  head/www/guacamole-client/files/logback.xml.sample
  head/www/guacamole-client/files/pkg-message.in
  head/www/guacamole-client/files/user-mapping.xml.sample
  head/www/guacamole-client/pkg-descr
  head/www/guacamole-client/pkg-plist

Comment 26 Kurt Jaeger 2016-02-06 21:01:06 UTC

Committed, thanks for your patience!