Bug 202773 - [MAINTAINER] multimedia/transcode: Remove USE_GCC, use newer options helper targets
Summary: [MAINTAINER] multimedia/transcode: Remove USE_GCC, use newer options helper t...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-30 16:34 UTC by Naram Qashat
Modified: 2015-12-29 09:17 UTC (History)
2 users (show)

See Also:

Attachments
transcode-1.1.7_23.patch (1.70 KB, patch)
2015-08-30 16:34 UTC, Naram Qashat 		no flags Details | Diff
Poudriere log (977.49 KB, text/plain)
2015-08-30 16:34 UTC, Naram Qashat 		no flags Details
QA: poudriere bulk -t -j 101i386 (failed) (202.50 KB, text/plain)
2015-09-11 22:30 UTC, Jan Beich 		no flags Details
Disable mmx on 10.1 (844 bytes, patch)
2015-12-28 17:45 UTC, Thomas Zander 		cyberbotx: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2015-08-30 16:34:26 UTC 
Created attachment 160528 [details]
transcode-1.1.7_23.patch

Remove USE_GCC=any as transcode builds just fine with clang.

Use the newer options helper targets for post-patch-*.

Poudriere log in the next reply.
Comment 1 Naram Qashat 2015-08-30 16:34:47 UTC 
Created attachment 160529 [details]
Poudriere log
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-09-11 22:28:43 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Sep 11 22:28:35 UTC 2015
New revision: 396719
URL: https://svnweb.freebsd.org/changeset/ports/396719

Log:
  multimedia/transcode: convert to target helpers

  - Reset option sorting to default (alphabetical)

  PR:		202773
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/multimedia/transcode/Makefile
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-09-11 22:30:26 UTC 
Created attachment 160943 [details]
QA: poudriere bulk -t -j 101i386 (failed)

Building with Clang still fails on at least 10.1-RELEASE i386.
Comment 4 Naram Qashat 2015-09-17 23:53:37 UTC 
This seems so weird to me, I built it without WITH_GCC in a 9.3-RELEASE poudriere jail and it builds fine with clang.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-21 11:35:25 UTC 
It fails only on 10.x i386, you should test on all supported versions and architectures.
Comment 6 Thomas Zander freebsd_committer freebsd_triage 2015-12-28 17:45:33 UTC 
Created attachment 164774 [details]
Disable mmx on 10.1

After the OPTION helpers have already been committed, the only remaining issue is to resolve this MMX compilation problem.

Of all the supported releases, this is actually a problem *only* on 10.1 due to a transient bug in clang that unfortunately made it into 10.1-RELEASE.
It's rare enough that only a handful of pieces of code in the world have been bitten, for example ffmpeg, see the thread at:
http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2013-October/150407.html

Attached patch removes the dependency on gcc and disables mmx only on FreeBSD-10 prior to 10.2.
I propose to commit this, then close this issue.
Comment 7 Naram Qashat 2015-12-29 01:09:09 UTC 
Comment on attachment 164774 [details]
Disable mmx on 10.1

This looks good to me, I'd be happy to get this bug closed out.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-12-29 09:16:03 UTC 
A commit references this bug:

Author: riggs
Date: Tue Dec 29 09:15:26 UTC 2015
New revision: 404718
URL: https://svnweb.freebsd.org/changeset/ports/404718

Log:
  Remove USE_GCC; add --disable-mmx on FreeBSD-10.1

  PR:		202773
  Submitted by:	cyberbotx@cyberbotx.com (maintainer)
  Reviewed by:	riggs

Changes:
  head/multimedia/transcode/Makefile